public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	"mingo@elte.hu" <mingo@elte.hu>,
	"ak@linux.intel.com" <ak@linux.intel.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH v2 2/2] perf stat: add interval printing
Date: Fri, 18 Jan 2013 15:09:02 +0100	[thread overview]
Message-ID: <20130118140902.GD1579@krava> (raw)
In-Reply-To: <CABPqkBS5uOSqM323XjRFwLXen29R=9Lejmp3EuSt3JhJa6fjHw@mail.gmail.com>

SNIP

> >> -     if (status != -1)
> >> +     if (status != -1 && !interval)
> >>               print_stat(argc, argv);
> >
> > The way this is done prevents final stats to be printed,
> > which seems unfortunate.
> >
> This is on purpose. All we care about here is the spaced deltas.
> Note that I also removed the shadow stats. Tried to make them
> work for a while but it did not make sense especially for -a -A.
> I don't think it even works right now.
> 
> > Actually I don't mind that much, because I haven't even thought about
> > this feature, but looks like it could be done separately with no affect
> > to final counts.
> >
> Initially I had it as raw_counts, prev_raw_counts. But then it would
> cause problems with the stats. So I simplified everything, it uses
> less memory and gives me the output I care about.
> 
> If you want total count, then don't use this new option. The results
> are to be fed to a plotter, so the final counts are useless and complicate
> the post-processing.

ok, agreed

jirka

> 
> > But since you probably use it mostly for feeding some graph ploting
> > program, it's probably fine.. just feels wrong ;-)

      parent reply	other threads:[~2013-01-18 14:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18 13:06 [PATCH v2 0/2] perf stat: add interval counter printing Stephane Eranian
2013-01-18 13:06 ` [PATCH v2 1/2] perf tools: add evsel prev_raw_count field Stephane Eranian
2013-01-18 13:49   ` Jiri Olsa
2013-01-18 13:06 ` [PATCH v2 2/2] perf stat: add interval printing Stephane Eranian
2013-01-18 13:50   ` Jiri Olsa
2013-01-18 13:59     ` Stephane Eranian
2013-01-18 14:05       ` Jiri Olsa
2013-01-18 14:09       ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130118140902.GD1579@krava \
    --to=jolsa@redhat.com \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung.kim@lge.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox