From: Felipe Balbi <balbi@ti.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: <balbi@ti.com>, Alan Stern <stern@rowland.harvard.edu>,
Venu Byravarasu <vbyravarasu@nvidia.com>,
<gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v3 4/4] usb: Add APIs to access host registers from Tegra PHY
Date: Fri, 18 Jan 2013 19:58:11 +0200 [thread overview]
Message-ID: <20130118175811.GD1035@arwen.pp.htv.fi> (raw)
In-Reply-To: <50F98646.6040209@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
On Fri, Jan 18, 2013 at 10:28:38AM -0700, Stephen Warren wrote:
> On 01/18/2013 08:30 AM, Alan Stern wrote:
> > On Fri, 18 Jan 2013, Venu Byravarasu wrote:
> >
> >> As Tegra PHY driver needs to access one of the Host registers,
> >> added few APIs.
> >>
> >> Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
> >> ---
> >> delta from v2:
> >> Renamed USB_PORTSC1 to TEGRA_USB_PORTSC1.
> >> Removed tegra_ehci_set_wakeon_events() and its references.
> >> Used standard defines for accessing PORTSC fields defined in ehci_def.h
> >> Included OCC bit of PORTSC as part of TEGRA_PORTSC1_RWC_BITS.
> >>
> >> delta from v1:
> >> Taken care of RWC bits, while accessing PORTSC register.
> >
> > Acked-by: Alan Stern <stern@rowland.harvard.edu>
>
> Felipe, you said on a previous version that you weren't sure if you
> could ack this since it means the PHY driver is touching EHCI
> registers... I don't think we really have much choice w.r.t. what the
> driver is doing, since it's driven purely by HW design. Is this updated
> patched at least OK for you not to NAK it, and hence I can apply it? Thanks.
Sure I will not block it, please go ahead and apply it through your tree
;-)
cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-01-18 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 6:15 [PATCH v3 4/4] usb: Add APIs to access host registers from Tegra PHY Venu Byravarasu
2013-01-18 15:30 ` Alan Stern
2013-01-18 17:28 ` Stephen Warren
2013-01-18 17:58 ` Felipe Balbi [this message]
2013-01-18 18:20 ` Stephen Warren
2013-01-18 19:36 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118175811.GD1035@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=swarren@wwwdotorg.org \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox