public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Borislav Petkov <bp@alien8.de>,
	"Gopalakrishnan, Aravind" <Aravind.Gopalakrishnan@amd.com>,
	"rjw@sisk.pl" <rjw@sisk.pl>, Andre Przywara <andre@andrep.de>,
	"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andreas <linuxuser330250@gmx.net>
Subject: Re: [PATCH] drivers/cpufreq: Warn user when powernow-k8 tries to fall back to acpi-cpufreq and it is unavailable.
Date: Fri, 18 Jan 2013 19:06:59 +0000	[thread overview]
Message-ID: <20130118190659.GB16757@srcf.ucam.org> (raw)
In-Reply-To: <20130118190021.GD4062@pd.tnic>

On Fri, Jan 18, 2013 at 08:00:21PM +0100, Borislav Petkov wrote:

> ##################################################################################
> # x86 drivers.
> # Link order matters. K8 is preferred to ACPI because of firmware bugs in early
> # K8 systems.
> ...
> 
> Great. :(

The only case I can see this hitting would be if the platform is using 
system IO rather than fixed hardware functionality. Easiest thing to do 
there would be something like this:

diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
index 0d048f6..8b466d5 100644
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -762,6 +762,11 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
 
 	switch (perf->control_register.space_id) {
 	case ACPI_ADR_SPACE_SYSTEM_IO:
+		if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) {
+			pr_debug("Old AMD systems must use native drivers\n");
+			result = -ENODEV;
+			goto err_unreg;
+		}
 		pr_debug("SYSTEM IO addr space\n");
 		data->cpu_feature = SYSTEM_IO_CAPABLE;
 		break;

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2013-01-18 19:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10  1:09 [PATCH] drivers/cpufreq: Warn user when powernow-k8 tries to fall back to acpi-cpufreq and it is unavailable Aravind Gopalakrishnan
2013-01-11 14:49 ` Borislav Petkov
2013-01-11 16:50   ` Borislav Petkov
2013-01-11 17:39     ` Gopalakrishnan, Aravind
2013-01-11 19:03     ` Gopalakrishnan, Aravind
2013-01-17 11:54       ` Borislav Petkov
2013-01-17 11:58         ` [PATCH] powernow-k8: Add a kconfig dependency on acpi-cpufreq Borislav Petkov
2013-01-17 12:53           ` Rafael J. Wysocki
2013-01-17 14:17             ` Borislav Petkov
2013-01-17 22:10               ` Rafael J. Wysocki
2013-01-17 22:12                 ` Borislav Petkov
2013-01-18 16:23         ` [PATCH] drivers/cpufreq: Warn user when powernow-k8 tries to fall back to acpi-cpufreq and it is unavailable Matthew Garrett
2013-01-18 17:07           ` Borislav Petkov
2013-01-18 19:00             ` Borislav Petkov
2013-01-18 19:06               ` Matthew Garrett [this message]
2013-01-18 19:36                 ` Borislav Petkov
2013-01-18 19:38                   ` Matthew Garrett
2013-01-18 19:58                     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130118190659.GB16757@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=Aravind.Gopalakrishnan@amd.com \
    --cc=andre@andrep.de \
    --cc=bp@alien8.de \
    --cc=cpufreq@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linuxuser330250@gmx.net \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox