public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sebastian Ehrenfels <qi50dube@cip.cs.fau.de>
Cc: linux-kernel@i4.informatik.uni-erlangen.de,
	devel@driverdev.osuosl.org,
	Dan Carpenter <dan.carpenter@oracle.com>,
	linux-kernel@vger.kernel.org,
	Sebastian Wankerl <sisewank@cip.cs.fau.de>
Subject: Re: [PATCH 2/3] wlan-ng/prism2mgmt.c: formated too long lines
Date: Fri, 18 Jan 2013 13:00:49 -0800	[thread overview]
Message-ID: <20130118210049.GA12463@kroah.com> (raw)
In-Reply-To: <1358464052-14002-3-git-send-email-qi50dube@cip.cs.fau.de>

On Fri, Jan 18, 2013 at 12:07:31AM +0100, Sebastian Ehrenfels wrote:
> From: Sebastian Wankerl <sisewank@cip.cs.fau.de>
> 
> Signed-off-by: Sebastian Wankerl <sisewank@cip.cs.fau.de> 
> Signed-off-by: Sebastian Ehrenfels <qi50dube@cip.cs.fau.de>
> 
> ---
>  drivers/staging/wlan-ng/prism2mgmt.c |   20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index 62b94b0..4b3db73 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -1144,9 +1144,9 @@ int prism2mgmt_wlansniff(wlandevice_t *wlandev, void *msgp)
>  			/* Enable the port */
>  			result = hfa384x_drvr_enable(hw, 0);
>  			if (result) {
> -				pr_debug
> -				("failed to enable port to presniff setting, result=%d\n",
> -				     result);
> +				pr_debug(
> +					"failed to enable port to presniff setting,"
> +					"result=%d\n", result);

No, please put the string on the same line as the pr_debug() call, and
don't break it across multiple lines.  This should look like:
				pr_debug("failed to enable port to presniff setting,result=%d\n",
					 result);

Can you please fix this up and resend it?

thanks,

greg k-h

  reply	other threads:[~2013-01-18 21:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 13:38 [PATCH 1/3] wlan-ng/prism2mgmt.c: added parenthesis to macro Sebastian Wankerl
2012-12-17 13:38 ` [PATCH 2/3] wlan-ng/prism2mgmt.c: formated too long lines Sebastian Wankerl
2012-12-17 14:08   ` Dan Carpenter
2012-12-17 13:38 ` [PATCH 3/3] wlan-ng/prism2mgmt.c Replace printk(...) with netdev_warn, netdev_err Sebastian Wankerl
2012-12-17 14:13   ` Dan Carpenter
2012-12-17 14:00 ` [PATCH 1/3] wlan-ng/prism2mgmt.c: added parenthesis to macro Dan Carpenter
2012-12-18 21:47   ` Sebastian Ehrenfels
2013-01-17 20:58 ` Greg Kroah-Hartman
2013-01-17 23:07   ` [i4passt_all] " Sebastian Ehrenfels
2013-01-17 23:07     ` Sebastian Ehrenfels
2013-01-18 21:02       ` Greg Kroah-Hartman
2013-01-17 23:07     ` [PATCH 2/3] wlan-ng/prism2mgmt.c: formated too long lines Sebastian Ehrenfels
2013-01-18 21:00       ` Greg Kroah-Hartman [this message]
2013-01-17 23:07     ` [PATCH 3/3] wlan-ng/prism2mgmt.c Replace printk(...) with netdev_warn, netdev_err Sebastian Ehrenfels
2013-01-18 21:01       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130118210049.GA12463@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@i4.informatik.uni-erlangen.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qi50dube@cip.cs.fau.de \
    --cc=sisewank@cip.cs.fau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox