From: Andi Kleen <ak@linux.intel.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, acme@redhat.com, jolsa@redhat.com,
namhyung.kim@lge.com
Subject: Re: [PATCH v6 08/18] perf/x86: add memory profiling via PEBS Load Latency
Date: Fri, 18 Jan 2013 15:12:12 -0800 [thread overview]
Message-ID: <20130118231212.GK4051@tassilo.jf.intel.com> (raw)
In-Reply-To: <1358264386-24633-9-git-send-email-eranian@google.com>
> + sample_type = event->attr.sample_type;
> +
> + /*
> + * if PEBS-LL or PreciseStore
> + */
> + if (fll) {
> + if (sample_type & PERF_SAMPLE_ADDR)
> + data.addr = pebs->dla;
> +
> + /*
> + * Use latency for weight (only avail with PEBS-LL)
> + */
> + if (fll && (sample_type & PERF_SAMPLE_WEIGHT))
The extra fll tests here don't make sense because it's always true inside
the if. You could remove the variable and the tests and only check once
in the if.
The rest looks good to me. There will be some conflicts with the Haswell
patches, but either of us can rebase.
Acked-by: Andi Kleen <ak@linux.intel.com>
-Andi
next prev parent reply other threads:[~2013-01-18 23:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 15:39 [PATCH v6 00/18] perf: add memory access sampling support Stephane Eranian
2013-01-15 15:39 ` [PATCH v6 01/18] perf, x86: Support CPU specific sysfs events Stephane Eranian
2013-01-15 15:39 ` [PATCH v6 02/18] perf/x86: improve sysfs event mapping with event string Stephane Eranian
2013-01-18 22:57 ` Andi Kleen
2013-01-15 15:39 ` [PATCH v6 03/18] perf/x86: add flags to event constraints Stephane Eranian
2013-01-18 22:59 ` Andi Kleen
2013-01-22 14:22 ` Stephane Eranian
2013-01-15 15:39 ` [PATCH v6 04/18] perf, core: Add a concept of a weightened sample Stephane Eranian
2013-01-15 15:39 ` [PATCH v6 05/18] perf: add minimal support for PERF_SAMPLE_WEIGHT Stephane Eranian
2013-01-18 23:00 ` Andi Kleen
2013-01-22 14:30 ` Stephane Eranian
2013-01-15 15:39 ` [PATCH v6 06/18] perf: add support for PERF_SAMPLE_ADDR in dump_sampple() Stephane Eranian
2013-01-15 15:39 ` [PATCH v6 07/18] perf: add generic memory sampling interface Stephane Eranian
2013-01-18 23:06 ` Andi Kleen
2013-01-23 16:54 ` Stephane Eranian
2013-01-15 15:39 ` [PATCH v6 08/18] perf/x86: add memory profiling via PEBS Load Latency Stephane Eranian
2013-01-18 23:12 ` Andi Kleen [this message]
2013-01-15 15:39 ` [PATCH v6 09/18] perf/x86: export PEBS load latency threshold register to sysfs Stephane Eranian
2013-01-15 15:39 ` [PATCH v6 10/18] perf/x86: add support for PEBS Precise Store Stephane Eranian
2013-01-18 23:21 ` Andi Kleen
2013-01-15 15:39 ` [PATCH v6 11/18] perf tools: add mem access sampling core support Stephane Eranian
2013-01-18 23:25 ` Andi Kleen
2013-01-15 15:39 ` [PATCH v6 12/18] perf report: add support for mem access profiling Stephane Eranian
2013-01-15 15:39 ` [PATCH v6 13/18] perf record: " Stephane Eranian
2013-01-15 15:39 ` [PATCH v6 14/18] perf tools: add new mem command for memory " Stephane Eranian
2013-01-15 15:39 ` [PATCH v6 15/18] perf: add PERF_RECORD_MISC_MMAP_DATA to RECORD_MMAP Stephane Eranian
2013-01-18 23:25 ` Andi Kleen
2013-01-15 15:39 ` [PATCH v6 16/18] perf tools: detect data vs. text mappings Stephane Eranian
2013-01-15 15:39 ` [PATCH v6 17/18] perf tools: Ignore ABS symbols when loading data maps Stephane Eranian
2013-01-15 15:39 ` [PATCH v6 18/18] perf tools: Fix output of symbol_daddr offset Stephane Eranian
2013-01-24 11:56 ` [PATCH v6 00/18] perf: add memory access sampling support Ingo Molnar
2013-01-24 13:39 ` Stephane Eranian
2013-01-24 13:41 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118231212.GK4051@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox