* [PATCH] Staging: zcache-main: Fixed Camel Case Issue
@ 2013-01-19 2:56 Jake Champlin
2013-01-19 3:08 ` Cong Ding
2013-01-19 10:53 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Jake Champlin @ 2013-01-19 2:56 UTC (permalink / raw)
To: gregkh
Cc: sjening, konrad.wilk, xiaoguangrong, dan.magenheimer, devel,
linux-kernel, jake.champlin.27
Fixed a camel case coding style issue.
Signed-off-by: Jake Champlin <jake.champlin.27@gmail.com>
---
drivers/staging/zcache/zcache-main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
index 52b43b7..95be348 100644
--- a/drivers/staging/zcache/zcache-main.c
+++ b/drivers/staging/zcache/zcache-main.c
@@ -1851,7 +1851,7 @@ static int zcache_frontswap_store(unsigned type, pgoff_t offset,
int ret = -1;
unsigned long flags;
- BUG_ON(!PageLocked(page));
+ BUG_ON(!page_locked(page));
if (likely(ind64 == ind)) {
local_irq_save(flags);
ret = zcache_put_page(LOCAL_CLIENT, zcache_frontswap_poolid,
@@ -1871,7 +1871,7 @@ static int zcache_frontswap_load(unsigned type, pgoff_t offset,
struct tmem_oid oid = oswiz(type, ind);
int ret = -1;
- BUG_ON(!PageLocked(page));
+ BUG_ON(!page_locked(page));
if (likely(ind64 == ind))
ret = zcache_get_page(LOCAL_CLIENT, zcache_frontswap_poolid,
&oid, iswiz(ind), page);
--
1.8.1.1
--
Jake Champlin
jake.champlin.27@gmail.com
8123742937
<MuttClient>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: zcache-main: Fixed Camel Case Issue
2013-01-19 2:56 [PATCH] Staging: zcache-main: Fixed Camel Case Issue Jake Champlin
@ 2013-01-19 3:08 ` Cong Ding
2013-01-19 10:53 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Cong Ding @ 2013-01-19 3:08 UTC (permalink / raw)
To: Jake Champlin
Cc: gregkh, sjening, konrad.wilk, xiaoguangrong, dan.magenheimer,
devel, linux-kernel
On Fri, Jan 18, 2013 at 09:56:44PM -0500, Jake Champlin wrote:
> Fixed a camel case coding style issue.
>
> Signed-off-by: Jake Champlin <jake.champlin.27@gmail.com>
> ---
> drivers/staging/zcache/zcache-main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
> index 52b43b7..95be348 100644
> --- a/drivers/staging/zcache/zcache-main.c
> +++ b/drivers/staging/zcache/zcache-main.c
> @@ -1851,7 +1851,7 @@ static int zcache_frontswap_store(unsigned type, pgoff_t offset,
> int ret = -1;
> unsigned long flags;
>
> - BUG_ON(!PageLocked(page));
> + BUG_ON(!page_locked(page));
> if (likely(ind64 == ind)) {
> local_irq_save(flags);
> ret = zcache_put_page(LOCAL_CLIENT, zcache_frontswap_poolid,
> @@ -1871,7 +1871,7 @@ static int zcache_frontswap_load(unsigned type, pgoff_t offset,
> struct tmem_oid oid = oswiz(type, ind);
> int ret = -1;
>
> - BUG_ON(!PageLocked(page));
> + BUG_ON(!page_locked(page));
again, that doesn't work. Did you try to build the code?
- cong
> if (likely(ind64 == ind))
> ret = zcache_get_page(LOCAL_CLIENT, zcache_frontswap_poolid,
> &oid, iswiz(ind), page);
> --
> 1.8.1.1
>
>
> --
> Jake Champlin
> jake.champlin.27@gmail.com
> 8123742937
> <MuttClient>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: zcache-main: Fixed Camel Case Issue
2013-01-19 2:56 [PATCH] Staging: zcache-main: Fixed Camel Case Issue Jake Champlin
2013-01-19 3:08 ` Cong Ding
@ 2013-01-19 10:53 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-01-19 10:53 UTC (permalink / raw)
To: Jake Champlin
Cc: gregkh, devel, sjening, konrad.wilk, linux-kernel, xiaoguangrong,
dan.magenheimer
On Fri, Jan 18, 2013 at 09:56:44PM -0500, Jake Champlin wrote:
> Fixed a camel case coding style issue.
>
Stop. It's not OK to break the build.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-19 10:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-19 2:56 [PATCH] Staging: zcache-main: Fixed Camel Case Issue Jake Champlin
2013-01-19 3:08 ` Cong Ding
2013-01-19 10:53 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox