* [PATCH]xfs: Fix xfs_swap_extents() after removal of xfs_flushinval_pages()
@ 2013-01-20 9:24 Torsten Kaiser
2013-01-28 22:42 ` Ben Myers
0 siblings, 1 reply; 2+ messages in thread
From: Torsten Kaiser @ 2013-01-20 9:24 UTC (permalink / raw)
To: Dave Chinner, xfs; +Cc: linux-kernel
From: Torsten Kaiser <just.for.lkml@googlemail.com>
Commit fb59581404ab7ec5075299065c22cb211a9262a9 removed
xfs_flushinval_pages() and changed its callers to use
filemap_write_and_wait() and truncate_pagecache_range() directly.
But in xfs_swap_extents() this change accidental switched the argument
for 'tip' to 'ip'. This patch switches it back to 'tip'
Signed-off-by: Torsten Kaiser <just.for.lkml@googlemail.com>
--- a/fs/xfs/xfs_dfrag.c
+++ b/fs/xfs/xfs_dfrag.c
@@ -246,10 +246,10 @@ xfs_swap_extents(
goto out_unlock;
}
- error = -filemap_write_and_wait(VFS_I(ip)->i_mapping);
+ error = -filemap_write_and_wait(VFS_I(tip)->i_mapping);
if (error)
goto out_unlock;
- truncate_pagecache_range(VFS_I(ip), 0, -1);
+ truncate_pagecache_range(VFS_I(tip), 0, -1);
/* Verify O_DIRECT for ftmp */
if (VN_CACHED(VFS_I(tip)) != 0) {
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH]xfs: Fix xfs_swap_extents() after removal of xfs_flushinval_pages()
2013-01-20 9:24 [PATCH]xfs: Fix xfs_swap_extents() after removal of xfs_flushinval_pages() Torsten Kaiser
@ 2013-01-28 22:42 ` Ben Myers
0 siblings, 0 replies; 2+ messages in thread
From: Ben Myers @ 2013-01-28 22:42 UTC (permalink / raw)
To: Torsten Kaiser; +Cc: Dave Chinner, xfs, linux-kernel
On Sun, Jan 20, 2013 at 10:24:49AM +0100, Torsten Kaiser wrote:
> From: Torsten Kaiser <just.for.lkml@googlemail.com>
>
> Commit fb59581404ab7ec5075299065c22cb211a9262a9 removed
> xfs_flushinval_pages() and changed its callers to use
> filemap_write_and_wait() and truncate_pagecache_range() directly.
>
> But in xfs_swap_extents() this change accidental switched the argument
> for 'tip' to 'ip'. This patch switches it back to 'tip'
>
> Signed-off-by: Torsten Kaiser <just.for.lkml@googlemail.com>
Looks good.
Reviewed-by: Ben Myers <bpm@sgi.com>
Thanks Torsten!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-28 22:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-20 9:24 [PATCH]xfs: Fix xfs_swap_extents() after removal of xfs_flushinval_pages() Torsten Kaiser
2013-01-28 22:42 ` Ben Myers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox