From: "Pali Rohár" <pali.rohar@gmail.com>
To: balbi@ti.com
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia
Date: Sun, 20 Jan 2013 11:17:31 +0100 [thread overview]
Message-ID: <201301201117.32096@pali> (raw)
In-Reply-To: <20130120092537.GB16066@arwen.pp.htv.fi>
[-- Attachment #1: Type: Text/Plain, Size: 782 bytes --]
On Sunday 20 January 2013 10:25:37 Felipe Balbi wrote:
> On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote:
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
>
> NAK for two reasons:
>
> a) the original Nokia kernel used a separate g_file_storage
> gadget to use Mass Storage mode, use that
>
> b) there is no commit log
Reason why add mass storage mode to g_nokia is to avoid switching
between g_{file,mass}_storage and g_nokia and to have one gadget
driver for Nokia N900. It is better to have usb network and mass
storage mode in one driver (and not to unload & load another).
I tested this patch with 3.8-rc3 kernel on Nokia N900 and usb
network with mass storage mode working without problems.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-01-20 10:17 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 2:58 [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia Pali Rohár
2013-01-20 9:25 ` Felipe Balbi
2013-01-20 10:17 ` Pali Rohár [this message]
2013-01-21 8:05 ` Felipe Balbi
2013-01-22 11:03 ` Pali Rohár
2013-01-22 16:17 ` Felipe Balbi
2013-01-22 21:46 ` Pali Rohár
2013-03-30 18:05 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2015-01-31 9:53 Pali Rohár
2015-02-02 10:56 ` Andrzej Pietrasiewicz
2015-02-02 18:54 ` Felipe Balbi
2015-02-02 18:58 ` Pali Rohár
2015-02-02 19:01 ` Felipe Balbi
2015-02-02 19:07 ` Pali Rohár
2015-02-02 19:14 ` Felipe Balbi
2015-02-05 12:45 ` Pali Rohár
2015-02-07 18:01 ` Ivaylo Dimitrov
2015-02-07 18:33 ` Ivaylo Dimitrov
2015-02-18 12:07 ` Pali Rohár
2015-02-18 12:07 ` Pali Rohár
2015-05-28 7:47 ` Pali Rohár
2015-05-28 14:27 ` Krzysztof Opasiak
2015-05-28 14:31 ` Pali Rohár
2015-05-28 14:51 ` Krzysztof Opasiak
2015-05-28 14:59 ` Pali Rohár
2015-05-28 16:34 ` Felipe Balbi
2015-05-28 21:40 ` Pali Rohár
2015-05-29 16:57 ` Felipe Balbi
2015-06-05 20:09 ` Pali Rohár
2015-06-05 20:17 ` Felipe Balbi
2015-06-06 8:04 ` Pali Rohár
2015-06-08 3:43 ` Felipe Balbi
2015-06-08 6:20 ` Pali Rohár
2015-06-08 16:08 ` Felipe Balbi
2015-07-06 11:59 ` Pali Rohár
2015-07-06 17:40 ` Felipe Balbi
2015-07-06 17:44 ` Felipe Balbi
2015-07-06 18:07 ` Pali Rohár
2015-07-06 18:10 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301201117.32096@pali \
--to=pali.rohar@gmail.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).