* [PATCH] Staging: ramster: zcache-main: Fixed Bracing Issues
@ 2013-01-19 4:09 Jake Champlin
2013-01-20 23:59 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jake Champlin @ 2013-01-19 4:09 UTC (permalink / raw)
To: gregkh
Cc: dan.magenheimer, sjenning, konrad.wilk, dan.carpenter, devel,
linux-kernel, jake.champlin.27
Fixed Coding Style Bracing Issues
Signed-off-by: Jake Champlin <jake.champlin.27@gmail.com>
---
drivers/staging/ramster/zcache-main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ramster/zcache-main.c b/drivers/staging/ramster/zcache-main.c
index a09dd5c..2613889 100644
--- a/drivers/staging/ramster/zcache-main.c
+++ b/drivers/staging/ramster/zcache-main.c
@@ -478,6 +478,7 @@ static void zcache_free_page(struct page *page)
#ifdef ZCACHE_DEBUG
if (curr_pageframes > 2L || curr_pageframes < -2L) {
/* pr_info here */
+ /* unnecessary comment */
}
#endif
}
@@ -1017,11 +1018,10 @@ static int zcache_frontswap_unuse(void)
unuse_ret = frontswap_unuse(type, offset,
newpage2 != NULL ? newpage2 : evictpage2,
ZCACHE_GFP_MASK);
- if (unuse_ret != 0) {
+ if (unuse_ret != 0)
goto free_and_out;
- } else if (evictpage2 != NULL) {
+ else if (evictpage2 != NULL)
zcache_unacct_page();
- }
}
ret = 0;
goto out;
--
1.8.1.1
--
Jake Champlin
jake.champlin.27@gmail.com
8123742937
<MuttClient>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: ramster: zcache-main: Fixed Bracing Issues
2013-01-19 4:09 [PATCH] Staging: ramster: zcache-main: Fixed Bracing Issues Jake Champlin
@ 2013-01-20 23:59 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2013-01-20 23:59 UTC (permalink / raw)
To: Jake Champlin
Cc: devel, sjenning, dan.magenheimer, konrad.wilk, linux-kernel,
dan.carpenter
On Fri, Jan 18, 2013 at 11:09:56PM -0500, Jake Champlin wrote:
> Fixed Coding Style Bracing Issues
>
> Signed-off-by: Jake Champlin <jake.champlin.27@gmail.com>
> ---
> drivers/staging/ramster/zcache-main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/ramster/zcache-main.c b/drivers/staging/ramster/zcache-main.c
> index a09dd5c..2613889 100644
> --- a/drivers/staging/ramster/zcache-main.c
> +++ b/drivers/staging/ramster/zcache-main.c
> @@ -478,6 +478,7 @@ static void zcache_free_page(struct page *page)
> #ifdef ZCACHE_DEBUG
> if (curr_pageframes > 2L || curr_pageframes < -2L) {
> /* pr_info here */
> + /* unnecessary comment */
> }
> #endif
> }
That doesn't look like it is fixing any coding style issues, you just
added a comment for no reason?
I understand it will shut checkpatch.pl up, but be reasonable here
please, it's a tool to be used as a guideline, use your judgement
please.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-20 23:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-19 4:09 [PATCH] Staging: ramster: zcache-main: Fixed Bracing Issues Jake Champlin
2013-01-20 23:59 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox