From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755786Ab3AUSYc (ORCPT ); Mon, 21 Jan 2013 13:24:32 -0500 Received: from mail.kernel.org ([198.145.19.201]:33853 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753644Ab3AUSYb (ORCPT ); Mon, 21 Jan 2013 13:24:31 -0500 Date: Mon, 21 Jan 2013 10:25:52 -0800 From: Greg KH To: Jon Mason Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Dave Jiang , Nicholas Bellinger Subject: Re: [PATCH 08/21] NTB: declare unused variables Message-ID: <20130121182552.GD5499@kroah.com> References: <1358586155-23322-1-git-send-email-jon.mason@intel.com> <1358586155-23322-9-git-send-email-jon.mason@intel.com> <20130120234228.GC14196@kroah.com> <20130121175054.GE22208@jonmason-lab> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130121175054.GE22208@jonmason-lab> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 21, 2013 at 10:50:55AM -0700, Jon Mason wrote: > On Sun, Jan 20, 2013 at 03:42:28PM -0800, Greg KH wrote: > > On Sat, Jan 19, 2013 at 02:02:22AM -0700, Jon Mason wrote: > > > Tag pci_device_id in ntb_pci_probe as unused function parameters. This > > > corrects issues found by 'EXTRA_CFLAGS=-W'. > > > > Why would you build the kernel with that option? This isn't needed, so > > Per Documentation/SubmitChecklist: > > 22: Newly-added code has been compiled with `gcc -W' (use "make > EXTRA_CFLAGS=-W"). This will generate lots of noise, but is good for > finding bugs like "warning: comparison between signed and unsigned". > > > I was attempting to comply with that suggestion. If this is > unnecessary, then I can toss these, but I don't really see them > hurting anything. It's messy and unneeded, so I'd not recommend using it. As the checklist says, it generates a lot of noise, and is good for finding real bugs, this isn't a "real" bug at all. > Same goes for the other 2 patches found via 'EXTRA_CFLAGS=-W'. Understood, I've not applied them either :) thanks, greg k-h