From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756472Ab3AUTDL (ORCPT ); Mon, 21 Jan 2013 14:03:11 -0500 Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:56116 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752599Ab3AUTDJ (ORCPT ); Mon, 21 Jan 2013 14:03:09 -0500 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+QelTHoE77aeP/mlt6S1Q0 Date: Mon, 21 Jan 2013 11:03:03 -0800 From: Tony Lindgren To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, Jason Cooper , Andrew Lunn , Gregory Clement Subject: Re: [PATCH 02/15] ARM: mvebu: build coherency_ll.S for arch=armv7-a Message-ID: <20130121190302.GN22517@atomide.com> References: <1358788568-11137-1-git-send-email-arnd@arndb.de> <1358788568-11137-3-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1358788568-11137-3-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnd Bergmann [130121 09:23]: > In a multiplatform kernel, one can enable mach-mvebu > together with one or more ARMv6 platforms, which leads > to all files being built for v6. The coherency_ll.S > uses the "dsb" instruction that is only available for > v7, causing a build error in this case. Since the > file is only used on v7 based machines, it is safe > to build it using an ".arch armv7-a" statement. > > Without this patch, building allyesconfig results in: > > arch/arm/mach-mvebu/coherency_ll.S: Assembler messages: > arch/arm/mach-mvebu/coherency_ll.S:45: Error: selected processor does not support ARM mode `dsb' This should be already fixed by 72533b (arm: mvebu: Fix compile for multiplatform when ARMv6 is selected) in arm-soc fixes branch. Regards, Tony > Signed-off-by: Arnd Bergmann > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Gregory Clement > --- > arch/arm/mach-mvebu/coherency_ll.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-mvebu/coherency_ll.S b/arch/arm/mach-mvebu/coherency_ll.S > index 53e8391..7648bda 100644 > --- a/arch/arm/mach-mvebu/coherency_ll.S > +++ b/arch/arm/mach-mvebu/coherency_ll.S > @@ -25,6 +25,7 @@ > * r0: Coherency fabric base register address > * r1: HW CPU id > */ > + .arch armv7-a > ENTRY(ll_set_cpu_coherent) > /* Create bit by cpu index */ > mov r3, #(1 << 24) > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/