From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756716Ab3AUU6v (ORCPT ); Mon, 21 Jan 2013 15:58:51 -0500 Received: from mail-pb0-f49.google.com ([209.85.160.49]:35766 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674Ab3AUU6u (ORCPT ); Mon, 21 Jan 2013 15:58:50 -0500 Date: Mon, 21 Jan 2013 12:58:46 -0800 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , LKML , "Kristen C. Accardi" , Len Brown Subject: Re: [RFC][Update 2][PATCH 4/4] ACPI / PM: Expose lists of device power resources to user space Message-ID: <20130121205846.GD17006@kroah.com> References: <3307415.pdOY6ovZLa@vostro.rjw.lan> <2096792.ELJ8WGVaaz@vostro.rjw.lan> <4247313.2G7Z3nCgM0@vostro.rjw.lan> <75501802.qSzsX3NXGt@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <75501802.qSzsX3NXGt@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 21, 2013 at 02:08:16PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Since ACPI power resources are going to be used more extensively on > new hardware platforms, it is necessary to allow user space (powertop > in particular) to look at the lists of power resources corresponding > to different power states of devices for diagnostics and control > purposes. > > For this reason, for each power state of an ACPI device node using > power resources create a special attribute group under the device > node's directory in sysfs containing links to sysfs directories > representing the power resources in that list. The names of the > new attribute groups are "power_resources_", where > is the state name i.e. "D0", "D1", "D2", or "D3hot". > > Signed-off-by: Rafael J. Wysocki You aren't calling sysfs_add_link() here, so why did you export it in the previous patch? thanks, greg k-h