* [PATCH 1/1] char: hw_random: Make exynos_rng_pm_ops static
@ 2013-01-21 11:45 Sachin Kamat
2013-01-21 22:28 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2013-01-21 11:45 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, mpm, herbert, sachin.kamat, Jonghwa Lee
'exynos_rng_pm_ops' is used only in this file. Without this patch
we get the following sparse warning:
drivers/char/hw_random/exynos-rng.c:165:1: warning:
symbol 'exynos_rng_pm_ops' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Jonghwa Lee <jonghwa3.lee@samsung.com>
---
drivers/char/hw_random/exynos-rng.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/hw_random/exynos-rng.c b/drivers/char/hw_random/exynos-rng.c
index 48bbfec..2a4a86d 100644
--- a/drivers/char/hw_random/exynos-rng.c
+++ b/drivers/char/hw_random/exynos-rng.c
@@ -162,7 +162,7 @@ static int exynos_rng_runtime_resume(struct device *dev)
}
-UNIVERSAL_DEV_PM_OPS(exynos_rng_pm_ops, exynos_rng_runtime_suspend,
+static UNIVERSAL_DEV_PM_OPS(exynos_rng_pm_ops, exynos_rng_runtime_suspend,
exynos_rng_runtime_resume, NULL);
static struct platform_driver exynos_rng_driver = {
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] char: hw_random: Make exynos_rng_pm_ops static
2013-01-21 11:45 [PATCH 1/1] char: hw_random: Make exynos_rng_pm_ops static Sachin Kamat
@ 2013-01-21 22:28 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2013-01-21 22:28 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, mpm, herbert, Jonghwa Lee
On Mon, Jan 21, 2013 at 05:15:49PM +0530, Sachin Kamat wrote:
> 'exynos_rng_pm_ops' is used only in this file. Without this patch
> we get the following sparse warning:
> drivers/char/hw_random/exynos-rng.c:165:1: warning:
> symbol 'exynos_rng_pm_ops' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Jonghwa Lee <jonghwa3.lee@samsung.com>
> ---
> drivers/char/hw_random/exynos-rng.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Sorry, someone else already sent in this patch on Saturday.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-21 22:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-21 11:45 [PATCH 1/1] char: hw_random: Make exynos_rng_pm_ops static Sachin Kamat
2013-01-21 22:28 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox