From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756919Ab3AUWiV (ORCPT ); Mon, 21 Jan 2013 17:38:21 -0500 Received: from mail-da0-f44.google.com ([209.85.210.44]:61790 "EHLO mail-da0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756880Ab3AUWiS (ORCPT ); Mon, 21 Jan 2013 17:38:18 -0500 Date: Mon, 21 Jan 2013 14:38:14 -0800 From: Greg Kroah-Hartman To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , LKML , "Kristen C. Accardi" , Len Brown Subject: Re: [RFC][Update 2][PATCH 3/4] sysfs: Functions for adding/removing symlinks to/from attribute groups Message-ID: <20130121223814.GA28518@kroah.com> References: <3307415.pdOY6ovZLa@vostro.rjw.lan> <7521411.VG2IjTvoWi@vostro.rjw.lan> <20130121205820.GC17006@kroah.com> <6110949.dY5glp6Ioa@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6110949.dY5glp6Ioa@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 21, 2013 at 11:41:35PM +0100, Rafael J. Wysocki wrote: > On Monday, January 21, 2013 12:58:20 PM Greg Kroah-Hartman wrote: > > On Mon, Jan 21, 2013 at 02:06:27PM +0100, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > The most convenient way to expose ACPI power resources lists of a > > > device is to put symbolic links to sysfs directories representing > > > those resources into special attribute groups in the device's sysfs > > > directory. For this purpose, it is necessary to be able to add > > > symbolic links to attribute groups. > > > > > > For this reason, add sysfs helper functions for adding/removing > > > symbolic links to/from attribute groups, sysfs_add_link_to_group() > > > and sysfs_remove_link_from_group(), respectively. > > > > Those functions are fine, but why sysfs_add_link()? > > Do you mean the helper? I couldn't invent a better name. :-) > > Would sysfs_create_link_sd() be better? That's a bit more descriptive, yes, and don't export it and I'll have no objections. thanks, greg k-h