From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756391Ab3AUXpB (ORCPT ); Mon, 21 Jan 2013 18:45:01 -0500 Received: from ch1ehsobe003.messaging.microsoft.com ([216.32.181.183]:6747 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753184Ab3AUXo7 (ORCPT ); Mon, 21 Jan 2013 18:44:59 -0500 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -2 X-BigFish: VS-2(zz98dI1432Izz1ee6h1de0h1202h1e76h1d1ah1d2ahzz17326ah8275bhz2dh2a8h668h839h944hd25hd2bhf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1155h) Date: Tue, 22 Jan 2013 07:44:49 +0800 From: Peter Chen To: Julia Lawall CC: Alexander Shishkin , , Greg Kroah-Hartman , , Subject: Re: [PATCH 2/15] drivers/usb/chipidea/core.c: adjust duplicate test Message-ID: <20130121234448.GB3978@nchen-desktop> References: <1358773378-4700-1-git-send-email-Julia.Lawall@lip6.fr> <1358773378-4700-3-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1358773378-4700-3-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.5.20 (2009-06-14) X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 21, 2013 at 02:02:46PM +0100, Julia Lawall wrote: > From: Julia Lawall > > Delete successive tests to the same location. In this case res has already > been tested for being NULL, and calling devm_request_and_ioremap will not > make it NULL. On the other hand, devm_request_and_ioremap can return NULL > on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @s exists@ > local idexpression y; > expression x,e; > @@ > > *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) ) > { ... when forall > return ...; } > ... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\) > when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\) > *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) ) > { ... when forall > return ...; } > // > > Signed-off-by: Julia Lawall > > --- > This code could be improved in other ways. The previous NULL test on res > is not needed, and the dev_err in the error-handling code for the call to > devm_request_and_ioremap is redundant with respect to the logging already > done by devm_request_and_ioremap. But these should probably be done > separately. > > drivers/usb/chipidea/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > index aebf695..57cae1f 100644 > --- a/drivers/usb/chipidea/core.c > +++ b/drivers/usb/chipidea/core.c > @@ -411,7 +411,7 @@ static int ci_hdrc_probe(struct platform_device *pdev) > } > > base = devm_request_and_ioremap(dev, res); > - if (!res) { > + if (!base) { > dev_err(dev, "can't request and ioremap resource\n"); > return -ENOMEM; > } > Tested-and-reviewed-by: Peter Chen -- Best Regards, Peter Chen