From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: cmetcalf@tilera.com, lttng-dev@lists.lttng.org,
linux-kernel@vger.kernel.org
Subject: Re: [lttng-dev] [PATCH 2/4] tile: Add definition of NR_syscalls
Date: Mon, 21 Jan 2013 20:06:53 -0500 [thread overview]
Message-ID: <20130122010653.GA27148@Krystal> (raw)
In-Reply-To: <1358816098-13070-2-git-send-email-simon.marchi@polymtl.ca>
* Simon Marchi (simon.marchi@polymtl.ca) wrote:
> It is required by the syscall tracepoint mechanism.
>
> Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
> ---
> arch/tile/include/uapi/asm/unistd.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/tile/include/uapi/asm/unistd.h b/arch/tile/include/uapi/asm/unistd.h
> index cd7b6dd..c763c86 100644
> --- a/arch/tile/include/uapi/asm/unistd.h
> +++ b/arch/tile/include/uapi/asm/unistd.h
> @@ -20,6 +20,8 @@
> /* Use the standard ABI for syscalls. */
> #include <asm-generic/unistd.h>
>
> +#define NR_syscalls (__NR_syscalls)
The parenthesis around __NR_syscalls seems unnecessary. (unless
parenthesis would happen to be missing around a __NR_syscalls definition
with multiple identifiers, but clearly, the parenthesis don't belong
here).
Thanks,
Mathieu
> +
> /* Additional Tilera-specific syscalls. */
> #define __NR_cacheflush (__NR_arch_specific_syscall + 1)
> __SYSCALL(__NR_cacheflush, sys_cacheflush)
> --
> 1.7.1
>
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2013-01-22 1:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 0:54 [PATCH 1/4] tile: move declaration of sys_call_table to <asm/syscall.h> Simon Marchi
2013-01-22 0:54 ` [PATCH 2/4] tile: Add definition of NR_syscalls Simon Marchi
2013-01-22 1:06 ` Mathieu Desnoyers [this message]
2013-01-22 0:54 ` [PATCH 3/4] tile: Add support for TIF_SYSCALL_TRACEPOINT Simon Marchi
2013-01-22 0:54 ` [PATCH 4/4] tile: select HAVE_SYSCALL_TRACEPOINTS Simon Marchi
2013-01-22 20:23 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122010653.GA27148@Krystal \
--to=mathieu.desnoyers@efficios.com \
--cc=cmetcalf@tilera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lttng-dev@lists.lttng.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox