From: Samuel Ortiz <sameo@linux.intel.com>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org,
Anmar Oueja <anmar.oueja@linaro.org>,
stable@kernel.org
Subject: Re: [PATCH v2] mfd: tc3589x: use simple irqdomain
Date: Tue, 22 Jan 2013 04:25:13 +0100 [thread overview]
Message-ID: <20130122032513.GG7409@sortiz-mobl> (raw)
In-Reply-To: <1357134014-31203-1-git-send-email-linus.walleij@stericsson.com>
Hi Linus,
On Wed, Jan 02, 2013 at 02:40:14PM +0100, Linus Walleij wrote:
> This fixes a regression in the TC3589x driver introduced in
> commit 15e27b1088245a2de3b7d09d39cd209212eb16af
> "mfd: Provide the tc3589x with its own IRQ domain"
>
> If a system with a TC3589x expander is booted and a base
> IRQ is passed from platform data, a legacy domain will
> be used. However, since the Ux500 is now switched to use
> SPARSE_IRQ, no descriptors get allocated on-the-fly,
> and we get a crash.
>
> Fix this by switching to using the simple irqdomain that
> will handle this uniformly and also allocates descriptors
> explicitly.
>
> Also fix two small whitespace errors in the vicinity while
> we're at it.
>
> Cc: stable@kernel.org
> Acked-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
> ---
> ChangeLog v1->v2:
> - Update commit message after comments from Lee, add ACK, no
> changes to the patche per se.
>
> Hi Sam, this should go into the fixes for stable unless issues
> are found, it fixes a regression for us.
Applied to my for-linus branch. On its way to 3.8.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2013-01-22 3:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-02 13:40 [PATCH v2] mfd: tc3589x: use simple irqdomain Linus Walleij
2013-01-14 22:28 ` Linus Walleij
2013-01-21 21:44 ` Linus Walleij
2013-01-22 3:25 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122032513.GG7409@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=anmar.oueja@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox