[PATCH] mfd: vexpress: export global functions to fix build error

[PATCH] mfd: vexpress: export global functions to fix build error

[Guenter Roeck]

Compiling vexpress client drivers as module results in error messages such as

ERROR: "__vexpress_config_func_get" [drivers/hwmon/vexpress.ko] undefined!
ERROR: "vexpress_config_func_put" [drivers/hwmon/vexpress.ko] undefined!

This is because the global functions in drivers/mfd/vexpress-config.c are not
exported. Fix it.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/mfd/vexpress-config.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/vexpress-config.c b/drivers/mfd/vexpress-config.c
index fae15d8..82fed98 100644
--- a/drivers/mfd/vexpress-config.c
+++ b/drivers/mfd/vexpress-config.c
@@ -67,6 +67,7 @@ struct vexpress_config_bridge *vexpress_config_bridge_register(
 
 	return bridge;
 }
+EXPORT_SYMBOL(vexpress_config_bridge_register);
 
 void vexpress_config_bridge_unregister(struct vexpress_config_bridge *bridge)
 {
@@ -83,6 +84,7 @@ void vexpress_config_bridge_unregister(struct vexpress_config_bridge *bridge)
 	while (!list_empty(&__bridge.transactions))
 		cpu_relax();
 }
+EXPOPORT_SYMBOL(vexpress_config_bridge_unregister);
 
 
 struct vexpress_config_func {
@@ -142,6 +144,7 @@ struct vexpress_config_func *__vexpress_config_func_get(struct device *dev,
 
 	return func;
 }
+EXPORT_SYMBOL(__vexpress_config_func_get);
 
 void vexpress_config_func_put(struct vexpress_config_func *func)
 {
@@ -149,7 +152,7 @@ void vexpress_config_func_put(struct vexpress_config_func *func)
 	of_node_put(func->bridge->node);
 	kfree(func);
 }
-
+EXPORT_SYMBOL(vexpress_config_func_put);
 
 struct vexpress_config_trans {
 	struct vexpress_config_func *func;
@@ -229,6 +232,7 @@ void vexpress_config_complete(struct vexpress_config_bridge *bridge,
 
 	complete(&trans->completion);
 }
+EXPORT_SYMBOL(vexpress_config_complete);
 
 int vexpress_config_wait(struct vexpress_config_trans *trans)
 {
@@ -236,7 +240,7 @@ int vexpress_config_wait(struct vexpress_config_trans *trans)
 
 	return trans->status;
 }
-
+EXPORT_SYMBOL(vexpress_config_wait);
 
 int vexpress_config_read(struct vexpress_config_func *func, int offset,
 		u32 *data)
-- 
1.7.9.7

Re: [PATCH] mfd: vexpress: export global functions to fix build error

[Pawel Moll]

On Sun, 2013-01-06 at 09:16 +0000, Guenter Roeck wrote:
> Compiling vexpress client drivers as module results in error messages such as
> 
> ERROR: "__vexpress_config_func_get" [drivers/hwmon/vexpress.ko] undefined!
> ERROR: "vexpress_config_func_put" [drivers/hwmon/vexpress.ko] undefined!
> 
> This is because the global functions in drivers/mfd/vexpress-config.c are not
> exported. Fix it.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Uh, right. Exported read/write but those are pretty much useless without
the other ones...

Thanks a lot, I'll get it queued with the other vexpress fixes and push
it upstream as soon as possible!

Pawel

Re: [PATCH] mfd: vexpress: export global functions to fix build error

[Samuel Ortiz]

Hi Guenter,

On Sun, Jan 06, 2013 at 01:16:19AM -0800, Guenter Roeck wrote:
> Compiling vexpress client drivers as module results in error messages such as
> 
> ERROR: "__vexpress_config_func_get" [drivers/hwmon/vexpress.ko] undefined!
> ERROR: "vexpress_config_func_put" [drivers/hwmon/vexpress.ko] undefined!
> 
> This is because the global functions in drivers/mfd/vexpress-config.c are not
> exported. Fix it.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/mfd/vexpress-config.c |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
Applied, thanks for the fix.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

Re: [PATCH] mfd: vexpress: export global functions to fix build error

[Guenter Roeck]

On Tue, Jan 22, 2013 at 04:30:42AM +0100, Samuel Ortiz wrote:
> Hi Guenter,
> 
> On Sun, Jan 06, 2013 at 01:16:19AM -0800, Guenter Roeck wrote:
> > Compiling vexpress client drivers as module results in error messages such as
> > 
> > ERROR: "__vexpress_config_func_get" [drivers/hwmon/vexpress.ko] undefined!
> > ERROR: "vexpress_config_func_put" [drivers/hwmon/vexpress.ko] undefined!
> > 
> > This is because the global functions in drivers/mfd/vexpress-config.c are not
> > exported. Fix it.
> > 
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> >  drivers/mfd/vexpress-config.c |    8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> Applied, thanks for the fix.
> 
Caution: Looks like I misspelled EXPORT_SYMBOL.

Guenter

Re: [PATCH] mfd: vexpress: export global functions to fix build error

[Samuel Ortiz]

Hi Guenter,

On Tue, Jan 22, 2013 at 04:20:26AM -0800, Guenter Roeck wrote:
> On Tue, Jan 22, 2013 at 04:30:42AM +0100, Samuel Ortiz wrote:
> > Hi Guenter,
> > 
> > On Sun, Jan 06, 2013 at 01:16:19AM -0800, Guenter Roeck wrote:
> > > Compiling vexpress client drivers as module results in error messages such as
> > > 
> > > ERROR: "__vexpress_config_func_get" [drivers/hwmon/vexpress.ko] undefined!
> > > ERROR: "vexpress_config_func_put" [drivers/hwmon/vexpress.ko] undefined!
> > > 
> > > This is because the global functions in drivers/mfd/vexpress-config.c are not
> > > exported. Fix it.
> > > 
> > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > > ---
> > >  drivers/mfd/vexpress-config.c |    8 ++++++--
> > >  1 file changed, 6 insertions(+), 2 deletions(-)
> > Applied, thanks for the fix.
> > 
> Caution: Looks like I misspelled EXPORT_SYMBOL.
I fixed that now.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/