Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

["Pali Rohár" <pali.rohar@gmail.com>]

[-- Attachment #1: Type: Text/Plain, Size: 2893 bytes --]

On Monday 21 January 2013 09:05:06 Felipe Balbi wrote:
> Hi,
> 
> On Sun, Jan 20, 2013 at 11:17:31AM +0100, Pali Rohár wrote:
> > On Sunday 20 January 2013 10:25:37 Felipe Balbi wrote:
> > > On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote:
> > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > 
> > > NAK for two reasons:
> > > 
> > > a) the original Nokia kernel used a separate
> > > g_file_storage gadget to use Mass Storage mode, use that
> > > 
> > > b) there is no commit log
> > 
> > Reason why add mass storage mode to g_nokia is to avoid
> > switching between g_{file,mass}_storage and g_nokia and to
> > have one gadget driver for Nokia N900. It is better to have
> > usb network and mass storage mode in one driver (and not to
> > unload & load another).
> > 
> > I tested this patch with 3.8-rc3 kernel on Nokia N900 and
> > usb network with mass storage mode working without
> > problems.
> 
> Doesn't matter, in this case this is something which nokia
> wrote to carry on their Maemo/MeeGo devices so unless someone
> from Nokia says this is how they want to use nokia.c from now
> on, I can't simply risk breaking all other users for your own
> convenience.
> 

Hello,

you may know that Nokia not working on any linux Maemo/MeeGo 
systems anymore. And also that Nokia devices needs own patched 
kernel. Also g_nokia gadget is for Nokia N900 and this device 
with original Maemo 5 system which was supported by Nokia is 
locked for patched 2.6.28 kernel. More drivers in 2.6.28 was not 
upstreamed, so running other kernels will not work without 
problems. And waiting what Nokia say is now irrelevant, because 
N900 is at end-of-live cycle and Nokia not doing with linux 
devices anymore. So I do not understand why current code cannot 
be extended for more functionality. Because patch is not signed 
by Nokia?

There are more developers which playing with upstream kernel on 
Nokia N900 and trying to use some modern linux distribution on 
it. And who using upstream kernels on N900 also want some 
additional functionality which was not in 2.6.28. And having mass 
storage in g_nokia is usefull.

Also you can see that this patch simply adding new composite 
gadget to exisitng driver. Nothing is removed, so original code 
is compatible with these changes. If somebody still want (for 
some reason) to switching between g_nokia and g_file_storage (ops, 
it was renamed to g_mass_storage, so now it is broken on old 
Nokia systems...) it is still possible.

And when I looked into nokia 2.6.28 kernel, they also patched 
g_file_storage, so I think it is incompatible with upstream too. 
So why to care about current API implementation in upstream 
kernel (do not allow to add new functionality) which is 
incompatible with Nokia patched kernel?

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]