From: Guenter Roeck <linux@roeck-us.net>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>
Subject: Re: [PATCH] mfd: vexpress: export global functions to fix build error
Date: Tue, 22 Jan 2013 04:20:26 -0800 [thread overview]
Message-ID: <20130122122026.GA12038@roeck-us.net> (raw)
In-Reply-To: <20130122033042.GV7409@sortiz-mobl>
On Tue, Jan 22, 2013 at 04:30:42AM +0100, Samuel Ortiz wrote:
> Hi Guenter,
>
> On Sun, Jan 06, 2013 at 01:16:19AM -0800, Guenter Roeck wrote:
> > Compiling vexpress client drivers as module results in error messages such as
> >
> > ERROR: "__vexpress_config_func_get" [drivers/hwmon/vexpress.ko] undefined!
> > ERROR: "vexpress_config_func_put" [drivers/hwmon/vexpress.ko] undefined!
> >
> > This is because the global functions in drivers/mfd/vexpress-config.c are not
> > exported. Fix it.
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > drivers/mfd/vexpress-config.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> Applied, thanks for the fix.
>
Caution: Looks like I misspelled EXPORT_SYMBOL.
Guenter
next prev parent reply other threads:[~2013-01-22 12:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 9:16 [PATCH] mfd: vexpress: export global functions to fix build error Guenter Roeck
2013-01-21 15:44 ` Pawel Moll
2013-01-22 3:30 ` Samuel Ortiz
2013-01-22 12:20 ` Guenter Roeck [this message]
2013-01-22 16:29 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122122026.GA12038@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox