From: Andrew Morton <akpm@linux-foundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH 1/6] cgroup: initialize cgrp->dentry before css_alloc()
Date: Tue, 22 Jan 2013 16:35:26 -0800 [thread overview]
Message-ID: <20130122163526.6c4ea765.akpm@linux-foundation.org> (raw)
In-Reply-To: <20130123002754.GB5359@htj.dyndns.org>
On Tue, 22 Jan 2013 16:27:54 -0800
Tejun Heo <tj@kernel.org> wrote:
> (cc'ing Andrew as scheduler folks are difficult to get response from
> these days and I can't think of anyone else to bother :)
>
> Hello, Li.
>
> The cgroup part looks good to me but it would be great if the
> descriptions are more detailed, especially, about why the change is
> beneficial or what it's aiming at. I take it that the shed changes
> are necessary to facilitate the later cgroup changes? Can you please
> elaborate how?
>
> The scheduler part of changes are mostly mechanical, so it would be
> great if we can get ack from scheduler people and route these together.
>
The sched parts do look pretty innocuous and could be viewed as "cgroup
stuff which happens to reside in kernel/sched/".
If you like the code, I think the best you can do is to merge it up,
make sure the sched guys are fully cc'ed then send it in to Linus.
next prev parent reply other threads:[~2013-01-23 0:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 8:03 [PATCH 1/6] cgroup: initialize cgrp->dentry before css_alloc() Li Zefan
2013-01-17 8:03 ` [PATCH 2/6] sched: split out tg creation/destruction to css_online/css_offline Li Zefan
2013-01-17 8:03 ` [PATCH 3/6] sched: remove redundant NULL cgroup check in task_group_path() Li Zefan
2013-01-17 8:04 ` [PATCH 4/6] cgroup: remove duplicate RCU free on struct cgroup Li Zefan
2013-01-17 8:04 ` [PATCH 5/6] cgroup: remove synchronize_rcu() from cgroup_diput() Li Zefan
2013-01-17 8:05 ` [PATCH 6/6] cgroup: remove bogus comments in cgroup_diput() Li Zefan
2013-01-23 0:27 ` [PATCH 1/6] cgroup: initialize cgrp->dentry before css_alloc() Tejun Heo
2013-01-23 0:35 ` Andrew Morton [this message]
2013-01-23 2:34 ` Li Zefan
2013-01-23 16:35 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122163526.6c4ea765.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).