From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Matt Wilson <msw@amazon.com>
Cc: linux-kernel@vger.kernel.org,
Ian Campbell <ian.campbell@citrix.com>,
netdev@vger.kernel.org, xen-devel@lists.xen.org
Subject: Re: [PATCH v2] xen-netback: allow changing the MAC address of the interface
Date: Tue, 22 Jan 2013 15:21:29 -0500 [thread overview]
Message-ID: <20130122202129.GB11982@phenom.dumpdata.com> (raw)
In-Reply-To: <1358878105-7890-1-git-send-email-msw@amazon.com>
On Tue, Jan 22, 2013 at 06:08:25PM +0000, Matt Wilson wrote:
> Sometimes it is useful to be able to change the MAC address of the
> interface for netback devices. For example, when using ebtables it may
> be useful to be able to distinguish traffic from different interfaces
> without depending on the interface name.
>
> Reported-by: Nikita Borzykh <sample.n@gmail.com>
> Reported-by: Paul Harvey <stockingpaul@hotmail.com>
> Cc: netdev@vger.kernel.org
> Cc: xen-devel@lists.xen.org
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> Signed-off-by: Matt Wilson <msw@amazon.com>
>
> ---
> Changes since v1:
> * No code changes, only updated commit message
> ---
> drivers/net/xen-netback/interface.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index b7d41f8..f733cae 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -238,6 +238,8 @@ static const struct net_device_ops xenvif_netdev_ops = {
> .ndo_stop = xenvif_close,
> .ndo_change_mtu = xenvif_change_mtu,
> .ndo_fix_features = xenvif_fix_features,
> + .ndo_set_mac_address = eth_mac_addr,
> + .ndo_validate_addr = eth_validate_addr,
> };
>
> struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
> --
> 1.7.4.5
>
next prev parent reply other threads:[~2013-01-22 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 18:08 [PATCH v2] xen-netback: allow changing the MAC address of the interface Matt Wilson
2013-01-22 20:21 ` Konrad Rzeszutek Wilk [this message]
2013-01-22 20:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122202129.GB11982@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=msw@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox