From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Kristen C. Accardi" <kristen.c.accardi@intel.com>,
Len Brown <lenb@kernel.org>
Subject: Re: [Update][PATCH 1/5] ACPI / scan: Prevent device add uevents from racing with user space
Date: Wed, 23 Jan 2013 16:33:19 -0800 [thread overview]
Message-ID: <20130124003319.GA10969@kroah.com> (raw)
In-Reply-To: <4119653.FS5BMPMa9z@vostro.rjw.lan>
On Wed, Jan 23, 2013 at 06:58:31PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> ACPI core adds sysfs device files after the given devices have been
> registered with device_register(), which is not appropriate, because
> it may lead to race conditions with user space tools using those
> files.
>
> Fix the problem by delaying the KOBJ_ADD uevent for ACPI devices
> until after all of the devices' sysfs files have been created.
>
> This also fixes a use-after-free in acpi_device_unregister().
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Nice fix.
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2013-01-24 0:33 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 14:51 [RFC][PATCH 0/3] ACPI / PM: Export power resources information to user space Rafael J. Wysocki
2013-01-20 14:53 ` [RFC][PATCH 1/3] ACPI / PM: Expose reference count values of ACPI power resources Rafael J. Wysocki
2013-01-20 14:54 ` [RFC][PATCH 2/3] sysfs: Functions for adding/removing symlinks to/from attribute groups Rafael J. Wysocki
2013-01-20 14:57 ` [RFC][PATCH 3/3] ACPI / PM: Expose lists of device power resources to user space Rafael J. Wysocki
2013-01-20 23:37 ` [RFC][PATCH 0/3] ACPI / PM: Export power resources information " Greg Kroah-Hartman
2013-01-21 0:11 ` Rafael J. Wysocki
2013-01-21 0:48 ` [RFC][Update][PATCH " Rafael J. Wysocki
2013-01-21 0:50 ` [RFC][Update][PATCH 1/3] ACPI / PM: Expose reference count values of ACPI power resources Rafael J. Wysocki
2013-01-21 0:51 ` [RFC][Update][PATCH 2/3] sysfs: Functions for adding/removing symlinks to/from attribute groups Rafael J. Wysocki
2013-01-21 0:53 ` [RFC][Update][PATCH 3/3] ACPI / PM: Expose lists of device power resources to user space Rafael J. Wysocki
2013-01-21 13:03 ` [RFC][Update 2][PATCH 0/4] ACPI / PM: Export power information " Rafael J. Wysocki
2013-01-21 13:04 ` [RFC][Update 2][PATCH 1/4] ACPI / PM: Export power states of ACPI devices via sysfs Rafael J. Wysocki
2013-01-21 20:53 ` Greg Kroah-Hartman
2013-01-21 22:27 ` Rafael J. Wysocki
2013-01-21 22:26 ` Greg Kroah-Hartman
2013-01-21 22:59 ` Rafael J. Wysocki
2013-01-21 23:08 ` Greg Kroah-Hartman
2013-01-22 0:48 ` Rafael J. Wysocki
2013-01-21 13:05 ` [RFC][Update 2][PATCH 2/4] ACPI / PM: Expose reference count values of ACPI power resources Rafael J. Wysocki
2013-01-21 20:53 ` Greg Kroah-Hartman
2013-01-21 22:35 ` Rafael J. Wysocki
2013-01-21 22:33 ` Greg Kroah-Hartman
2013-01-21 13:06 ` [RFC][Update 2][PATCH 3/4] sysfs: Functions for adding/removing symlinks to/from attribute groups Rafael J. Wysocki
2013-01-21 20:58 ` Greg Kroah-Hartman
2013-01-21 22:41 ` Rafael J. Wysocki
2013-01-21 22:38 ` Greg Kroah-Hartman
2013-01-21 13:08 ` [RFC][Update 2][PATCH 4/4] ACPI / PM: Expose lists of device power resources to user space Rafael J. Wysocki
2013-01-21 20:58 ` Greg Kroah-Hartman
2013-01-21 22:42 ` Rafael J. Wysocki
2013-01-22 2:15 ` [PATCH 0/4] ACPI / PM: Export power information " Rafael J. Wysocki
2013-01-22 2:25 ` [PATCH 1/4] ACPI / PM: Expose power states of ACPI devices " Rafael J. Wysocki
2013-01-22 23:42 ` Greg Kroah-Hartman
2013-01-22 23:47 ` Greg Kroah-Hartman
2013-01-23 0:01 ` Rafael J. Wysocki
2013-01-22 23:58 ` Greg Kroah-Hartman
2013-01-22 2:26 ` [PATCH 2/4] ACPI / PM: Expose current status of ACPI power resources Rafael J. Wysocki
2013-01-22 23:49 ` Greg Kroah-Hartman
2013-01-22 2:27 ` [PATCH 3/4] sysfs: Functions for adding/removing symlinks to/from attribute groups Rafael J. Wysocki
2013-01-22 23:51 ` Greg Kroah-Hartman
2013-01-23 0:03 ` Rafael J. Wysocki
2013-01-22 2:28 ` [PATCH 4/4] ACPI / PM: Expose lists of device power resources to user space Rafael J. Wysocki
2013-01-22 23:56 ` Greg Kroah-Hartman
2013-01-23 0:08 ` Rafael J. Wysocki
2013-01-23 0:17 ` Rafael J. Wysocki
2013-01-23 0:28 ` Rafael J. Wysocki
2013-01-23 1:05 ` Greg Kroah-Hartman
2013-01-23 14:01 ` Rafael J. Wysocki
2013-01-23 1:03 ` Greg Kroah-Hartman
2013-01-23 14:00 ` Rafael J. Wysocki
2013-01-23 17:56 ` [Update][PATCH 0/5] ACPI / PM: Export power information " Rafael J. Wysocki
2013-01-23 17:58 ` [Update][PATCH 1/5] ACPI / scan: Prevent device add uevents from racing with " Rafael J. Wysocki
2013-01-24 0:33 ` Greg Kroah-Hartman [this message]
2013-01-23 17:59 ` [Update][PATCH 2/5] ACPI / PM: Expose power states of ACPI devices to " Rafael J. Wysocki
2013-01-23 18:00 ` [Update][PATCH 3/5] ACPI / PM: Expose current status of ACPI power resources Rafael J. Wysocki
2013-01-23 18:00 ` [Update][PATCH 4/5] sysfs: Functions for adding/removing symlinks to/from attribute groups Rafael J. Wysocki
2013-01-24 0:33 ` Greg Kroah-Hartman
2013-01-25 20:13 ` [patch] sysfs: Fix build when sysfs is disabled David Rientjes
2013-01-25 20:42 ` Greg Kroah-Hartman
2013-01-25 20:53 ` Rafael J. Wysocki
2013-01-25 20:52 ` Rafael J. Wysocki
2013-01-25 21:34 ` David Rientjes
2013-01-23 18:01 ` [Update][PATCH 5/5] ACPI / PM: Expose lists of device power resources to user space Rafael J. Wysocki
2013-01-24 0:34 ` Greg Kroah-Hartman
2013-01-24 0:34 ` [Update][PATCH 0/5] ACPI / PM: Export power information " Greg Kroah-Hartman
2013-01-24 12:34 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124003319.GA10969@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kristen.c.accardi@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox