linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Laurent Navet <laurent.navet@gmail.com>
Cc: khali@linux-fr.org, ben-linux@fluff.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: i2c-nforce2: fix coding style issues
Date: Thu, 24 Jan 2013 08:27:24 +0100	[thread overview]
Message-ID: <20130124072723.GI8364@nekote.pengutronix.de> (raw)
In-Reply-To: <1357826862-4975-1-git-send-email-laurent.navet@gmail.com>

On Thu, Jan 10, 2013 at 03:07:42PM +0100, Laurent Navet wrote:
> avoid these checkpatch.pl issues :
> - ERROR: "foo * bar" should be "foo *bar"
> - ERROR: switch and case should be at the same indent
> - ERROR: "(foo*)" should be "(foo *)"
> - ERROR: do not use assignment in if condition
> - ERROR: space required before the open parenthesis '('
> - WARNING: suspect code indent for conditional statements
> - WARNING: quoted string split across lines
> - WARNING: space prohibited between function name and open parenthesis '('
> - WARNING: line over 80 characters
> also add spaces around some "+", "=", "*"
> 
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>

Thanks, applied to for-next.


  parent reply	other threads:[~2013-01-24  7:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10 14:07 [PATCH] drivers: i2c-nforce2: fix coding style issues Laurent Navet
2013-01-10 16:34 ` Jean Delvare
2013-01-24  7:27 ` Wolfram Sang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-01-09 20:50 Laurent Navet
2013-01-10  8:32 ` Jean Delvare
2013-01-10  8:52   ` Laurent Navet
2013-01-10  9:21     ` Jean Delvare
2013-01-10  9:40       ` Wolfram Sang
2012-12-19 21:06 Laurent Navet
2012-12-21 10:04 ` Jean Delvare
2012-12-21 14:15   ` Laurent Navet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130124072723.GI8364@nekote.pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=ben-linux@fluff.org \
    --cc=khali@linux-fr.org \
    --cc=laurent.navet@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).