Re: [PATCH v6 08/18] perf/x86: add memory profiling via PEBS Load Latency

Andi Kleen
2013-01-18T23:12:21Z

> + sample_type = event->attr.sample_type;
> +
> + /*
> + * if PEBS-LL or PreciseStore
> + */
> + if (fll) {
> + if (sample_type & PERF_SAMPLE_ADDR)
> + data.addr = pebs->dla;
> +
> + /*
> + * Use latency for weight (only avail with PEBS-LL)
> + */
> + if (fll && (sample_type & PERF_SAMPLE_WEIGHT))

The extra fll tests here don't make sense because it's always true inside
the if. You could remove the variable and the tests and only check once
in the if.

The rest looks good to me. There will be some conflicts with the Haswell
patches, but either of us can rebase.

Acked-by: Andi Kleen <ak@linux.intel.com>

-Andi