public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Clark Williams <williams@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2] sched: add a tuning knob to allow changing RR tmeslice
Date: Thu, 24 Jan 2013 17:59:55 +0100	[thread overview]
Message-ID: <20130124165955.GA9324@gmail.com> (raw)
In-Reply-To: <20121108195113.2dd51d43@redhat.com>


* Clark Williams <williams@redhat.com> wrote:

> This version stores the user-input value in a separate 
> location from the jiffies values used by the scheduler, to 
> prevent a race condition.
> 
> Subject: [PATCH v2] sched: add a tuning knob to allow changing 
> RR timeslice

looks useful.

> @@ -2010,7 +2010,7 @@ static void task_tick_rt(struct rq *rq, struct
> task_struct *p, int queued) if (--p->rt.time_slice)
>  		return;
>  
> -	p->rt.time_slice = RR_TIMESLICE;
> +	p->rt.time_slice = sched_rr_timeslice;
>  
>  	/*
>  	 * Requeue to the end of queue if we (and all of our
> ancestors) are the @@ -2041,7 +2041,7 @@ static unsigned int
> get_rr_interval_rt(struct rq *rq, struct task_struct *task)
>  	 * Time slice is 0 for SCHED_FIFO tasks

Patch wont apply due to patch corruption, alas.

Thanks,

	Ingo

  reply	other threads:[~2013-01-24 17:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09  1:51 [PATCH v2] sched: add a tuning knob to allow changing RR tmeslice Clark Williams
2013-01-24 16:59 ` Ingo Molnar [this message]
2013-01-24 19:54   ` Clark Williams
2013-01-25  8:19     ` Ingo Molnar
2013-01-25 18:02       ` Clark Williams
2013-01-25 18:36         ` Ingo Molnar
2013-01-25 21:43           ` Clark Williams
2013-01-26 12:16             ` Ingo Molnar
2013-01-26 12:18             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130124165955.GA9324@gmail.com \
    --to=mingo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox