From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754199Ab3AXRRp (ORCPT ); Thu, 24 Jan 2013 12:17:45 -0500 Received: from mail-pb0-f53.google.com ([209.85.160.53]:52317 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752142Ab3AXRRn (ORCPT ); Thu, 24 Jan 2013 12:17:43 -0500 Date: Thu, 24 Jan 2013 09:17:40 -0800 From: "gregkh@linuxfoundation.org" To: KY Srinivasan Cc: Jiri Kosina , "olaf@aepfle.de" , "jasowang@redhat.com" , "linux-kernel@vger.kernel.org" , "James.Bottomley@HansenPartnership.com" , "apw@canonical.com" , "devel@linuxdriverproject.org" , "davem@davemloft.net" Subject: Re: [PATCH 6/6] Drivers: hv: Execute shutdown in a thread context Message-ID: <20130124171740.GA5420@kroah.com> References: <1358991737-22675-1-git-send-email-kys@microsoft.com> <1358991765-22715-1-git-send-email-kys@microsoft.com> <1358991765-22715-6-git-send-email-kys@microsoft.com> <53da151ef8494d5084ef5aa089b9f102@SN2PR03MB061.namprd03.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53da151ef8494d5084ef5aa089b9f102@SN2PR03MB061.namprd03.prod.outlook.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 24, 2013 at 05:06:27PM +0000, KY Srinivasan wrote: > > > > -----Original Message----- > > From: Jiri Kosina [mailto:jkosina@suse.cz] > > Sent: Thursday, January 24, 2013 5:10 AM > > To: KY Srinivasan > > Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org; > > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; > > jasowang@redhat.com; davem@davemloft.net; > > James.Bottomley@HansenPartnership.com > > Subject: Re: [PATCH 6/6] Drivers: hv: Execute shutdown in a thread context > > > > On Wed, 23 Jan 2013, K. Y. Srinivasan wrote: > > > > > Execute the shutdown code in a thread context. With recent changes made to > > the > > > shutdown code, shutdown code cannot be invoked from an interrupt context. > > > > > > Signed-off-by: K. Y. Srinivasan > > > Reviewed-by: Haiyang Zhang > > > --- > > > drivers/hv/hv_util.c | 12 +++++++++++- > > > 1 files changed, 11 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c > > > index 8b7868a..aceb67f 100644 > > > --- a/drivers/hv/hv_util.c > > > +++ b/drivers/hv/hv_util.c > > > @@ -49,6 +49,16 @@ static struct hv_util_service util_kvp = { > > > .util_deinit = hv_kvp_deinit, > > > }; > > > > > > +static void perform_shutdown(struct work_struct *dummy) > > > +{ > > > + orderly_poweroff(true); > > > +} > > > > Is there any particular reason for this kind of crazy indentation? > I don't know how this extra tab crept through! Greg, if you want I can resend > this patch minus the extra tab. Let me know. I'll edit it by hand, but someone owes me a beer for it... :) greg k-h