public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Huewe <PeterHuewe@gmx.de>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: Ian Abbott <ian.abbott@mev.co.uk>,
	Mori Hess <fmhess@users.sourceforge.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging/comedi: Move comedi_pci_auto_unconfig to drivers.c
Date: Thu, 24 Jan 2013 22:30:49 +0100	[thread overview]
Message-ID: <201301242230.49732.PeterHuewe@gmx.de> (raw)
In-Reply-To: <510106BB.2080709@mev.co.uk>

Am Donnerstag, 24. Januar 2013, 11:02:35 schrieb Ian Abbott:
> On 2013-01-22 23:03, Peter Huewe wrote:
> > Since comedi_pci_auto_unconfig cannot be inlined anymore after
> > 
> >   staging/comedi: Use comedi_pci_auto_unconfig directly for
> >   pci_driver.remove
> > 
> > is applied, it makes sense to move it drivers.c
> > 
> > Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> > ---
> > 

> Embarassingly (for me) I submitted a patch to do the exact opposite
> previously, but I've no problem doing it this way if it saves some code.

Hi Ian,
;)

If you think it's cleaner the way it is currently we can leave it like that. 
Especially if you think some driver might actually do something in the remove 
function (in the future).

However if we could also find a way to remove all the probe function stuff as 
well we should remove it.
Most (comedi pci) drivers simply call comedi_pci_auto_config and not much more 
- but I'm currently not sure how to do this ;)

Thanks,
PeterH


  reply	other threads:[~2013-01-24 21:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-22 22:40 [PATCH] staging/comedi: Use comedi_pci_auto_unconfig directly for pci_driver.remove Peter Huewe
2013-01-22 22:49 ` H Hartley Sweeten
2013-01-22 23:02   ` Peter Hüwe
2013-01-22 23:03 ` [PATCH] staging/comedi: Move comedi_pci_auto_unconfig to drivers.c Peter Huewe
2013-01-24 10:02   ` Ian Abbott
2013-01-24 21:30     ` Peter Huewe [this message]
2013-01-25 10:58       ` Ian Abbott
2013-01-25 20:09   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201301242230.49732.PeterHuewe@gmx.de \
    --to=peterhuewe@gmx.de \
    --cc=abbotti@mev.co.uk \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=ian.abbott@mev.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox