From: Al Viro <viro@ZenIV.linux.org.uk>
To: Matt Fleming <matt.fleming@intel.com>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC] efivars write(2) races
Date: Fri, 25 Jan 2013 00:25:53 +0000 [thread overview]
Message-ID: <20130125002552.GC4503@ZenIV.linux.org.uk> (raw)
1) process A does write() on efivars file, reaches ->get_variable(),
gets newdatasize set, drops efivars->lock and loses CPU before an attempt to
grab ->i_mutex. process B comes and does the same thing, replacing the
variable contents. Then it grabs ->i_mutex, updates size, drops ->i_mutex
and buggers off. At which point A gets CPU back and proceeds to set size
to whatever would be valid for its write. Only the value is bogus now...
2) what's to prevent EFI_NOT_FOUND being hit twice? Bad things
will obviously happen in that case...
next reply other threads:[~2013-01-25 0:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 0:25 Al Viro [this message]
2013-01-25 3:50 ` [RFC] efivars write(2) races Lingzhu Xiang
2013-01-25 13:18 ` Matt Fleming
2013-01-28 2:38 ` Lingzhu Xiang
2013-01-28 12:38 ` Matt Fleming
2013-01-29 2:30 ` Lingzhu Xiang
2013-01-25 12:50 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125002552.GC4503@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox