From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Thomas Jarosch <thomas.jarosch@intra2net.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [perf PATCH 3/3] Fix double fclose() on do_write(fd, xxx) failure
Date: Fri, 25 Jan 2013 13:01:51 -0300 [thread overview]
Message-ID: <20130125160151.GA31242@ghostprotocols.net> (raw)
In-Reply-To: <2684910.12iLzy42t4@storm>
Em Fri, Jan 25, 2013 at 11:22:17AM +0100, Thomas Jarosch escreveu:
> cppcheck reported:
> [util/header.c:983]: (error) Used file that is not opened.
>
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> ---
> tools/perf/util/header.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 7b24cf3..30745c2 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -955,6 +955,7 @@ static int write_topo_node(int fd, int node)
> }
>
> fclose(fp);
> + fp = NULL;
Ok, but what is the behaviour of fclose(NULL)? Is it defined?
- Arnaldo
next prev parent reply other threads:[~2013-01-25 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 10:22 [perf PATCH 3/3] Fix double fclose() on do_write(fd, xxx) failure Thomas Jarosch
2013-01-25 16:01 ` Arnaldo Carvalho de Melo [this message]
2013-01-28 8:31 ` Thomas Jarosch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125160151.GA31242@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.jarosch@intra2net.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox