* [perf PATCH 3/3] Fix double fclose() on do_write(fd, xxx) failure
@ 2013-01-25 10:22 Thomas Jarosch
2013-01-25 16:01 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Jarosch @ 2013-01-25 10:22 UTC (permalink / raw)
To: acme; +Cc: linux-kernel
cppcheck reported:
[util/header.c:983]: (error) Used file that is not opened.
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---
| 1 +
1 file changed, 1 insertion(+)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 7b24cf3..30745c2 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -955,6 +955,7 @@ static int write_topo_node(int fd, int node)
}
fclose(fp);
+ fp = NULL;
ret = do_write(fd, &mem_total, sizeof(u64));
if (ret)
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [perf PATCH 3/3] Fix double fclose() on do_write(fd, xxx) failure
2013-01-25 10:22 [perf PATCH 3/3] Fix double fclose() on do_write(fd, xxx) failure Thomas Jarosch
@ 2013-01-25 16:01 ` Arnaldo Carvalho de Melo
2013-01-28 8:31 ` Thomas Jarosch
0 siblings, 1 reply; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-01-25 16:01 UTC (permalink / raw)
To: Thomas Jarosch; +Cc: linux-kernel
Em Fri, Jan 25, 2013 at 11:22:17AM +0100, Thomas Jarosch escreveu:
> cppcheck reported:
> [util/header.c:983]: (error) Used file that is not opened.
>
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> ---
> tools/perf/util/header.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 7b24cf3..30745c2 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -955,6 +955,7 @@ static int write_topo_node(int fd, int node)
> }
>
> fclose(fp);
> + fp = NULL;
Ok, but what is the behaviour of fclose(NULL)? Is it defined?
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [perf PATCH 3/3] Fix double fclose() on do_write(fd, xxx) failure
2013-01-25 16:01 ` Arnaldo Carvalho de Melo
@ 2013-01-28 8:31 ` Thomas Jarosch
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Jarosch @ 2013-01-28 8:31 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: linux-kernel
On Friday, 25. January 2013 13:01:51 you wrote:
> Em Fri, Jan 25, 2013 at 11:22:17AM +0100, Thomas Jarosch escreveu:
> > cppcheck reported:
> > [util/header.c:983]: (error) Used file that is not opened.
> >
> > Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
> > ---
> >
> > tools/perf/util/header.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> > index 7b24cf3..30745c2 100644
> > --- a/tools/perf/util/header.c
> > +++ b/tools/perf/util/header.c
> > @@ -955,6 +955,7 @@ static int write_topo_node(int fd, int node)
> >
> > }
> >
> > fclose(fp);
> >
> > + fp = NULL;
>
> Ok, but what is the behaviour of fclose(NULL)? Is it defined?
>
> - Arnaldo
Grrr, this is undefined behavior. Sorry. I always thought this
is defined like free(NULL) but apparently it is not.
I'll send another version of the patch and also write to the
man page maintainer to add a small hint to the fclose() man page.
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-28 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-25 10:22 [perf PATCH 3/3] Fix double fclose() on do_write(fd, xxx) failure Thomas Jarosch
2013-01-25 16:01 ` Arnaldo Carvalho de Melo
2013-01-28 8:31 ` Thomas Jarosch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox