From: Josh Triplett <josh@joshtriplett.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: mingo@kernel.org, tglx@linutronix.de, mjg@redhat.com,
linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [tip:x86/debug] x86/EFI: Properly init-annotate BGRT code
Date: Fri, 25 Jan 2013 08:03:09 -0800 [thread overview]
Message-ID: <20130125160309.GA15960@leaf> (raw)
In-Reply-To: <5102463602000078000B9761@nat28.tlf.novell.com>
On Fri, Jan 25, 2013 at 07:45:42AM +0000, Jan Beulich wrote:
> >>> On 24.01.13 at 23:28, Josh Triplett <josh@joshtriplett.org> wrote:
> > On Thu, Jan 24, 2013 at 12:34:21PM -0800, tip-bot for Jan Beulich wrote:
> >> Commit-ID: 13f0e4d2b9e2209f13d5a4122478eb79e6136870
> >> Gitweb:
> > http://git.kernel.org/tip/13f0e4d2b9e2209f13d5a4122478eb79e6136870
> >> Author: Jan Beulich <JBeulich@suse.com>
> >> AuthorDate: Fri, 23 Nov 2012 16:30:07 +0000
> >> Committer: Ingo Molnar <mingo@kernel.org>
> >> CommitDate: Thu, 24 Jan 2013 17:12:18 +0100
> >>
> >> x86/EFI: Properly init-annotate BGRT code
> >>
> >> These items are only ever referenced from initialization code.
> >
> > Not true, and this patch will break the BGRT code. bgrt_init, which
> > does indeed have an __init annotation, stores bgrt_image and
> > bgrt_image_size into the .private and .size fields of a sysfs
> > bin_attribute, which does *not* have an __initdata annotation, and which
> > will get read whenever the user reads the corresponding sysfs attribute.
>
> Copying init-only data into a sysfs structure is no problem at all
> - that structure obviously is non-__initdata and hence can be
> read at any time. It was a different thing if .private and/or .size
> stored _pointers_ to one of the two variables in question.
Ah, I see; the data itself gets kmalloc'd, and you just want to discard
the original pointer and size. Fair enough. Sorry for the false alarm.
- Josh Triplett
next prev parent reply other threads:[~2013-01-25 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 16:30 [PATCH] x86/EFI: properly init-annotate BGRT code Jan Beulich
2013-01-24 20:34 ` [tip:x86/debug] x86/EFI: Properly " tip-bot for Jan Beulich
2013-01-24 22:28 ` Josh Triplett
2013-01-25 7:45 ` Jan Beulich
2013-01-25 16:03 ` Josh Triplett [this message]
2013-01-25 18:36 ` Ingo Molnar
2013-01-25 19:18 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125160309.GA15960@leaf \
--to=josh@joshtriplett.org \
--cc=JBeulich@suse.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mjg@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox