public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Venu Byravarasu <vbyravarasu@nvidia.com>
Subject: Re: Crash with 9fdb04c "async: replace list of active domains with global list of pending items"
Date: Fri, 25 Jan 2013 09:19:20 -0800	[thread overview]
Message-ID: <20130125171920.GF3081@htj.dyndns.org> (raw)
In-Reply-To: <510216ED.1090602@wwwdotorg.org>

Hello,

On Thu, Jan 24, 2013 at 09:23:57PM -0800, Stephen Warren wrote:
> In next-20130124, I see a crash during boot on my ARM system unless I
> revert 9fdb04c "async: replace list of active domains with global list
> of pending items". This was reported t me by Venu (CC'd). The kernel log
> is below.
> 
> Looking at that patch, I note that __async_schedule() does:
> 
> > 	list_add_tail(&entry->domain_list, &domain->pending);
> > 	if (domain->registered)
> > 		list_add_tail(&entry->global_list, &async_global_pending);
> 
> ... whereas async_run_entry_fn() unconditionally undoes both those
> list_add_tail() calls, even if the second never executed and hence the
> list entry was never initialized:
> 
> > 	list_del_init(&entry->domain_list);
> > 	list_del_init(&entry->global_list);

Was reported by James Hogan a bit earlier and fix has been applied.

  http://thread.gmane.org/gmane.linux.kernel/1425387/focus=1429460

Thanks!

-- 
tejun

      reply	other threads:[~2013-01-25 17:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-25  5:23 Crash with 9fdb04c "async: replace list of active domains with global list of pending items" Stephen Warren
2013-01-25 17:19 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130125171920.GF3081@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=vbyravarasu@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox