From: Ingo Molnar <mingo@kernel.org>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: linux-tip-commits@vger.kernel.org, hpa@zytor.com,
linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
tglx@linutronix.de
Subject: Re: [tip:x86/platform] x86: Add TS-5500 platform support
Date: Fri, 25 Jan 2013 19:38:25 +0100 [thread overview]
Message-ID: <20130125183825.GC31022@gmail.com> (raw)
In-Reply-To: <1344460915.280514.1359132048723.JavaMail.root@mail.savoirfairelinux.com>
* Vivien Didelot <vivien.didelot@savoirfairelinux.com> wrote:
> Hi Ingo,
>
> > This patch still appears to have some problems with certain
> > (rare) LEDS .config variations:
> >
> > arch/x86/built-in.o: In function `ts5500_init':
> > ts5500.c:(.init.text+0xdae6): undefined reference to
> > `led_classdev_register'
> >
> > Config attached.
> >
> > Please fix & resend.
>
> I think the attached config might not be the right one. [...]
Hm, yes - sorry. The failure happened on a testbox and I might
have misplaced the config.
> [...] This issue happens when the ts5500 support is selected
> (CONFIG_TS5500=y) but the LED class (CONFIG_NEW_LEDS and
> CONFIG_LEDS_CLASS) is not.
>
> Thanks for pointing this out.
> The following patch below solves this issue. Is it ok, or should
> I resend to whole board support patch?
This one's OK, I'll resurrect the old one and amend it with your
delta fix.
Thanks!
Ingo
next prev parent reply other threads:[~2013-01-25 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 21:18 [PATCH] x86: add TS-5500 platform support Vivien Didelot
2013-01-24 20:18 ` [tip:x86/platform] x86: Add " tip-bot for Vivien Didelot
2013-01-25 7:37 ` Ingo Molnar
2013-01-25 16:40 ` Vivien Didelot
2013-01-25 18:38 ` Ingo Molnar [this message]
2013-01-26 12:22 ` tip-bot for Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125183825.GC31022@gmail.com \
--to=mingo@kernel.org \
--cc=hpa@zytor.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox