Re: [tip:x86/platform] x86: Add TS-5500 platform support

Ingo Molnar
2013-01-25T18:38:31Z

* Vivien Didelot <vivien.didelot@savoirfairelinux.com> wrote:

> Hi Ingo,
>
> > This patch still appears to have some problems with certain
> > (rare) LEDS .config variations:
> >
> > arch/x86/built-in.o: In function `ts5500_init':
> > ts5500.c:(.init.text+0xdae6): undefined reference to
> > `led_classdev_register'
> >
> > Config attached.
> >
> > Please fix & resend.
>
> I think the attached config might not be the right one. [...]

Hm, yes - sorry. The failure happened on a testbox and I might
have misplaced the config.

> [...] This issue happens when the ts5500 support is selected
> (CONFIG_TS5500=y) but the LED class (CONFIG_NEW_LEDS and
> CONFIG_LEDS_CLASS) is not.
>
> Thanks for pointing this out.
> The following patch below solves this issue. Is it ok, or should
> I resend to whole board support patch?

This one's OK, I'll resurrect the old one and amend it with your
delta fix.

Thanks!

Ingo