Re: [Update][PATCH 0/5] ACPI / PM: Export power information to user space

Greg Kroah-Hartman
2013-01-24T00:34:51Z

On Wed, Jan 23, 2013 at 06:56:43PM +0100, Rafael J. Wysocki wrote:
> On Tuesday, January 22, 2013 03:15:52 AM Rafael J. Wysocki wrote:
> > On Monday, January 21, 2013 02:03:03 PM Rafael J. Wysocki wrote:
> > > On Monday, January 21, 2013 01:48:55 AM Rafael J. Wysocki wrote:
> > > > On Sunday, January 20, 2013 03:51:40 PM Rafael J. Wysocki wrote:
> > > > > Hi Greg,
> > > > >
> > > > > The following patch series is about exporting ACPI power resources to user
> > > > > space that will be necessary for PM diagnostics on new platforms (powertop is
> > > > > the target). Still, existing systems can also benefit from that, like my
> > > > > oldish HP nx6325 on which the patches have been tested.
> > > > >
> > > > > Patch [1/3] shouldn't be really controverisal, as it only makes it possible
> > > > > to read power resources' reference counters from user space in a quite
> > > > > straightforward way.
> > > > >
> > > > > Patch [3/3], however, exposes lists of power resources associated with
> > > > > different power states of devices using ACPI PM as sysfs subdirectories
> > > > > containing symbolic links and that requires some sysfs changes made by
> > > > > patch [2/3].
> > > > >
> > > > > Admittedly, my sysfs skills are limited so please let me know if those
> > > > > changes make sense and are acceptable from your perspective. If not, then
> > > > > please kindly advise what I can do instead of them.
> > > > >
> > > > > The patches apply on top of the current linux-next branch of the linux-pm.git
> > > > > tree.
> > > >
> > > > Refreshed with Documentation/ABI files as requested.
> > >
> > > Well, that version wasn't really a good one, due to mistakes in the docs
> > > mostly, so a new one follows (with better docs hopefully).
> > >
> > > Besides, I thought I'd include a patch that exposes ACPI power state
> > > information, because it kind of belongs to the lot. It goes as the new [1/4].
> > >
> > > [2/4] is the previous [1/3] and so on.
> >
> > Here it goes again after the changes we discussed earlier today.
> >
> > I think I've addressed all of the comments, but if I overlooked something,
> > please let me know.
>
> So, the following is an update containing a patch ([1/5]) that fixes the
> "creation of sysfs files after the device have been registered" problem.
> Hopefully. :-)
>
> Patches [2-3/5] are the previous [1-2/4] and they are almost identical as
> before, so I added the ACKs you gave for them. Patch [4/5] is the sysfs one
> with the internal function placed in the internal header. Patch [5/5] is
> a rework of the one exposing the lists of power resources as directories
> containing symbolic links.
>
> Please let me know if you are fine with this.

These all look great, thanks for fixing up the acpi device notification
mess, and the sysfs header file locations. Feel free to take all of
these through your tree.

greg k-h