Re: [patch] sysfs: Fix build when sysfs is disabled

Rafael J. Wysocki
2013-01-25T20:47:37Z

On Friday, January 25, 2013 12:42:34 PM Greg Kroah-Hartman wrote:
> On Fri, Jan 25, 2013 at 12:13:59PM -0800, David Rientjes wrote:
> > "sysfs: Functions for adding/removing symlinks to/from attribute groups"
> > causes a build failure when CONFIG_SYSFS is disabled:
> >
> > drivers/acpi/power.c: In function 'acpi_power_hide_list':
> > drivers/acpi/power.c:463: error: implicit declaration of function 'sysfs_remove_link_from_group'
> > drivers/acpi/power.c: In function 'acpi_power_expose_list':
> > drivers/acpi/power.c:486: error: implicit declaration of function 'sysfs_add_link_to_group'
> >
> > We need to define empty functions for this config to avoid ifdefs in the
> > code.
> >
> > Signed-off-by: David Rientjes <rientjes@google.com>
> > ---
> > include/linux/sysfs.h | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Rafael has to take this through his tree.

Thanks for the patch and review.

I will fold it into the original patch to reduce bisection pain.

Thanks,
Rafael

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.