* [PATCH] regulators/db8500: Fix compile failure for drivers/regulator/dbx500-prcmu.c
@ 2013-01-24 15:29 Steven Rostedt
2013-01-26 7:31 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2013-01-24 15:29 UTC (permalink / raw)
To: LKML, linux-arm-kernel
Cc: Bengt Jonsson, Linus Walleij, Mark Brown, Russell King
Building for the snowball board, I ran into this compile failure:
CC drivers/regulator/dbx500-prcmu.o
arm-test.git/drivers/regulator/dbx500-prcmu.c:119:11: error: 'THIS_MODULE' undeclared here (not in a function)
make[3]: *** [drivers/regulator/dbx500-prcmu.o] Error 1
make[2]: *** [drivers/regulator] Error 2
Commit 38e968380 "regulators/db8500: split off shared dbx500 code"
separated out the dbx500 code but did not copy over the required include
to linux/module.h.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
diff --git a/drivers/regulator/dbx500-prcmu.c b/drivers/regulator/dbx500-prcmu.c
index 261f3d2..89bd2fa 100644
--- a/drivers/regulator/dbx500-prcmu.c
+++ b/drivers/regulator/dbx500-prcmu.c
@@ -14,6 +14,7 @@
#include <linux/debugfs.h>
#include <linux/seq_file.h>
#include <linux/slab.h>
+#include <linux/module.h>
#include "dbx500-prcmu.h"
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulators/db8500: Fix compile failure for drivers/regulator/dbx500-prcmu.c
2013-01-24 15:29 [PATCH] regulators/db8500: Fix compile failure for drivers/regulator/dbx500-prcmu.c Steven Rostedt
@ 2013-01-26 7:31 ` Mark Brown
2013-01-26 13:26 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2013-01-26 7:31 UTC (permalink / raw)
To: Steven Rostedt
Cc: LKML, linux-arm-kernel, Bengt Jonsson, Linus Walleij,
Russell King
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
On Thu, Jan 24, 2013 at 10:29:26AM -0500, Steven Rostedt wrote:
> Building for the snowball board, I ran into this compile failure:
Applied, thanks. Please use subject lines appropriate for the subsystem
(I see I let the original one through).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulators/db8500: Fix compile failure for drivers/regulator/dbx500-prcmu.c
2013-01-26 7:31 ` Mark Brown
@ 2013-01-26 13:26 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2013-01-26 13:26 UTC (permalink / raw)
To: Mark Brown
Cc: LKML, linux-arm-kernel, Bengt Jonsson, Linus Walleij,
Russell King
On Sat, 2013-01-26 at 15:31 +0800, Mark Brown wrote:
> Applied, thanks. Please use subject lines appropriate for the subsystem
> (I see I let the original one through).
Heh, when making patches for other subsystems, I look at the subject of
the patch that broke to determine what to use.
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-26 13:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-24 15:29 [PATCH] regulators/db8500: Fix compile failure for drivers/regulator/dbx500-prcmu.c Steven Rostedt
2013-01-26 7:31 ` Mark Brown
2013-01-26 13:26 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox