From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753700Ab3AZMLA (ORCPT <rfc822;w@1wt.eu>);
	Sat, 26 Jan 2013 07:11:00 -0500
Received: from mail-ee0-f51.google.com ([74.125.83.51]:51975 "EHLO
	mail-ee0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753464Ab3AZMK4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 26 Jan 2013 07:10:56 -0500
Date: Sat, 26 Jan 2013 13:10:51 +0100
From: Ingo Molnar <mingo@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, konrad.wilk@oracle.com,
        torvalds@linux-foundation.org, JBeulich@suse.com, tglx@linutronix.de,
        linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/asm] x86/xor: Make virtualization friendly
Message-ID: <20130126121051.GF13445@gmail.com>
References: <5093E4F302000078000A6162@nat28.tlf.novell.com>
 <tip-05fbf4d6fc6a3c0c3e63b77979c9311596716d10@git.kernel.org>
 <510302FD.3090009@zytor.com>
 <510303F8.1080105@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <510303F8.1080105@zytor.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* H. Peter Anvin <hpa@zytor.com> wrote:

> On 01/25/2013 02:11 PM, H. Peter Anvin wrote:
> > On 01/25/2013 02:43 AM, tip-bot for Jan Beulich wrote:
> >> Commit-ID:  05fbf4d6fc6a3c0c3e63b77979c9311596716d10
> >> Gitweb:     http://git.kernel.org/tip/05fbf4d6fc6a3c0c3e63b77979c9311596716d10
> >> Author:     Jan Beulich <JBeulich@suse.com>
> >> AuthorDate: Fri, 2 Nov 2012 14:21:23 +0000
> >> Committer:  Ingo Molnar <mingo@kernel.org>
> >> CommitDate: Fri, 25 Jan 2013 09:23:51 +0100
> >>
> >> x86/xor: Make virtualization friendly
> >>
> >> In virtualized environments, the CR0.TS management needed here
> >> can be a lot slower than anticipated by the original authors of
> >> this code, which particularly means that in such cases forcing
> >> the use of SSE- (or MMX-) based implementations is not desirable
> >> - actual measurements should always be done in that case.
> >>
> >> For consistency, pull into the shared (32- and 64-bit) header
> >> not only the inclusion of the generic code, but also that of the
> >> AVX variants.
> >>
> > 
> > This patch is wrong and should be dropped.  I verified it with the KVM
> > people that they do NOT want this change.  It is a Xen-specific problem.
> > 
> 
> FWIW: I have dropped this patch from tip:x86/asm.

Thanks - and the other two patches are fine, right?

	Ingo