From: Samuel Ortiz <sameo@linux.intel.com>
To: Ashish Jangam <ashish.jangam@kpitcummins.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Axel Lin <axel.lin@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
David Dajun Chen <dchen@diasemi.com>
Subject: Re: [PATCH v1/1] mfd: i2c issue fix for da9052/53
Date: Sun, 27 Jan 2013 01:36:04 +0100 [thread overview]
Message-ID: <20130127003604.GH1174@sortiz-mobl> (raw)
In-Reply-To: <1359102829.6620.10.camel@dhruva>
Hi Ashish,
On Fri, Jan 25, 2013 at 02:03:49PM +0530, Ashish Jangam wrote:
> An issue has been reported where the PMIC either locks up or fails to
> respond following a system Reset. This could result in a second write
> in which the bus writes the current content of the write buffer to address
> of the last I2C access.
>
> The failure case is where this unwanted write transfers incorrect data to
> a critical register.
>
> This patch fixes this issue to by following any read or write with a dummy read
> to a safe register address. A safe register address is one where the contents
> will not affect the operation of the system.
>
> Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>
> ---
> drivers/mfd/da9052-i2c.c | 61 ++++++++++++++++++++++++++++++++++
> include/linux/mfd/da9052/da9052.h | 66 ++++++++++++++++++++++++++++++++++--
> include/linux/mfd/da9052/reg.h | 3 ++
> 3 files changed, 126 insertions(+), 4 deletions(-)
Applied to my for-linus branch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2013-01-27 0:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 8:33 [PATCH v1/1] mfd: i2c issue fix for da9052/53 Ashish Jangam
2013-01-27 0:36 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130127003604.GH1174@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dchen@diasemi.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox