* [patch] NTB: fix pointer math issues
@ 2013-01-23 19:26 Dan Carpenter
2013-01-28 2:51 ` Jon Mason
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-01-23 19:26 UTC (permalink / raw)
To: Jon Mason; +Cc: linux-kernel, kernel-janitors
->remote_rx_info and ->rx_info are struct ntb_rx_info pointers. If we
add sizeof(struct ntb_rx_info) then it goes too far.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
index e0bdfd7..676ee16 100644
--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -486,7 +486,7 @@ static void ntb_transport_setup_qp_mw(struct ntb_transport *nt,
(qp_num / NTB_NUM_MW * rx_size);
rx_size -= sizeof(struct ntb_rx_info);
- qp->rx_buff = qp->remote_rx_info + sizeof(struct ntb_rx_info);
+ qp->rx_buff = qp->remote_rx_info + 1;
qp->rx_max_frame = min(transport_mtu, rx_size);
qp->rx_max_entry = rx_size / qp->rx_max_frame;
qp->rx_index = 0;
@@ -780,7 +780,7 @@ static void ntb_transport_init_queue(struct ntb_transport *nt,
(qp_num / NTB_NUM_MW * tx_size);
tx_size -= sizeof(struct ntb_rx_info);
- qp->tx_mw = qp->rx_info + sizeof(struct ntb_rx_info);
+ qp->tx_mw = qp->rx_info + 1;
qp->tx_max_frame = min(transport_mtu, tx_size);
qp->tx_max_entry = tx_size / qp->tx_max_frame;
qp->tx_index = 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] NTB: fix pointer math issues
2013-01-23 19:26 [patch] NTB: fix pointer math issues Dan Carpenter
@ 2013-01-28 2:51 ` Jon Mason
0 siblings, 0 replies; 2+ messages in thread
From: Jon Mason @ 2013-01-28 2:51 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-kernel, kernel-janitors
On Wed, Jan 23, 2013 at 10:26:05PM +0300, Dan Carpenter wrote:
> ->remote_rx_info and ->rx_info are struct ntb_rx_info pointers. If we
> add sizeof(struct ntb_rx_info) then it goes too far.
Good catch, I'll add it to me pending patch queue.
Thanks,
Jon
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index e0bdfd7..676ee16 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -486,7 +486,7 @@ static void ntb_transport_setup_qp_mw(struct ntb_transport *nt,
> (qp_num / NTB_NUM_MW * rx_size);
> rx_size -= sizeof(struct ntb_rx_info);
>
> - qp->rx_buff = qp->remote_rx_info + sizeof(struct ntb_rx_info);
> + qp->rx_buff = qp->remote_rx_info + 1;
> qp->rx_max_frame = min(transport_mtu, rx_size);
> qp->rx_max_entry = rx_size / qp->rx_max_frame;
> qp->rx_index = 0;
> @@ -780,7 +780,7 @@ static void ntb_transport_init_queue(struct ntb_transport *nt,
> (qp_num / NTB_NUM_MW * tx_size);
> tx_size -= sizeof(struct ntb_rx_info);
>
> - qp->tx_mw = qp->rx_info + sizeof(struct ntb_rx_info);
> + qp->tx_mw = qp->rx_info + 1;
> qp->tx_max_frame = min(transport_mtu, tx_size);
> qp->tx_max_entry = tx_size / qp->tx_max_frame;
> qp->tx_index = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-28 2:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-23 19:26 [patch] NTB: fix pointer math issues Dan Carpenter
2013-01-28 2:51 ` Jon Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox