From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754200Ab3A1DoJ (ORCPT ); Sun, 27 Jan 2013 22:44:09 -0500 Received: from LGEMRELSE1Q.lge.com ([156.147.1.111]:62908 "EHLO LGEMRELSE1Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753547Ab3A1DoG (ORCPT ); Sun, 27 Jan 2013 22:44:06 -0500 X-AuditID: 9c93016f-b7b70ae000000e36-b7-5105f40350f5 Date: Mon, 28 Jan 2013 12:44:04 +0900 From: Minchan Kim To: Seth Jennings Cc: Greg Kroah-Hartman , Andrew Morton , Dan Magenheimer , Konrad Rzeszutek Wilk , Nitin Gupta , Robert Jennings , linux-mm@kvack.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] staging: zsmalloc: make CLASS_DELTA relative to PAGE_SIZE Message-ID: <20130128034404.GD3321@blaptop> References: <1359135978-15119-1-git-send-email-sjenning@linux.vnet.ibm.com> <1359135978-15119-5-git-send-email-sjenning@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1359135978-15119-5-git-send-email-sjenning@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 25, 2013 at 11:46:18AM -0600, Seth Jennings wrote: > Right now ZS_SIZE_CLASS_DELTA is hardcoded to be 16. This > creates 254 classes for systems with 4k pages. However, on > PPC64 with 64k pages, it creates 4095 classes which is far > too many. > > This patch makes ZS_SIZE_CLASS_DELTA relative to PAGE_SIZE > so that regardless of the page size, there will be the same > number of classes. > > Acked-by: Nitin Gupta > Signed-off-by: Seth Jennings Acked-by: Minchan Kim -- Kind regards, Minchan Kim