From: Aristeu Rozanski <aris@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH v2] userns: improve uid/gid map collision detection
Date: Mon, 28 Jan 2013 09:25:50 -0500 [thread overview]
Message-ID: <20130128142550.GT17632@redhat.com> (raw)
In-Reply-To: <871ud8hdyu.fsf@xmission.com>
On Fri, Jan 25, 2013 at 06:31:37PM -0800, Eric W. Biederman wrote:
> Aritsteu after looking at both my version and yours I am going with
one extra t.
> mine. While my code is a little wordier I have half the number of
> comparisons your code does, and I took the time to kill the variable
> introducing a function to test for range collisions makes unnecessary.
> On Andrews size metric my version seems noticably smaller as well.
>
> size $PWD-build/kernel/user_namespace.o
> text data bss dec hex filename
> 4376 144 0 4520 11a8 /home/eric/projects/linux/linux-userns-devel-build/kernel/user_namespace.o
>
>
> Short of something unexpected I plan to push all my code to linux-next
> sometime tomorrow.
sure, no problem
Thanks Eric
--
Aristeu
prev parent reply other threads:[~2013-01-28 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 16:02 [PATCH] userns: improve uid/gid map collision detection Aristeu Rozanski
2013-01-24 4:44 ` Serge E. Hallyn
2013-01-24 15:28 ` [PATCH v2] " Aristeu Rozanski
2013-01-25 0:46 ` Andrew Morton
2013-01-25 2:00 ` Eric W. Biederman
2013-01-25 14:03 ` Aristeu Rozanski
2013-01-26 2:31 ` Eric W. Biederman
2013-01-28 14:25 ` Aristeu Rozanski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130128142550.GT17632@redhat.com \
--to=aris@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox