Re: [PATCH 1/4] staging: zsmalloc: add gfp flags to zs_create_pool

Minchan Kim
2013-01-28T23:33:35Z

On Mon, Jan 28, 2013 at 10:16:38AM -0500, Konrad Rzeszutek Wilk wrote:
> On Mon, Jan 28, 2013 at 12:39:44PM +0900, Minchan Kim wrote:
> > Hi Seth,
> >
> > On Fri, Jan 25, 2013 at 11:46:15AM -0600, Seth Jennings wrote:
> > > zs_create_pool() currently takes a gfp flags argument
> > > that is used when growing the memory pool. However
> > > it is not used in allocating the metadata for the pool
> > > itself. That is currently hardcoded to GFP_KERNEL.
> > >
> > > zswap calls zs_create_pool() at swapon time which is done
> > > in atomic context, resulting in a "might sleep" warning.
> > >
> > > This patch changes the meaning of the flags argument in
> > > zs_create_pool() to mean the flags for the metadata allocation,
> > > and adds a flags argument to zs_malloc that will be used for
> > > memory pool growth if required.
> >
> > As I mentioned, I'm not strongly against with this patch but it
> > should be last resort in case of not being able to address
> > frontswap's init routine's dependency with swap_lock.
> >
> > I sent a patch and am waiting reply of Konrand or Dan.
> > If we can fix frontswap, it would be better rather than
> > changing zsmalloc.
>
> Could you point me to the subject/title of it please? Thanks.

I am very happy if you review it.

https://lkml.org/lkml/2013/1/27/262

Thanks.

>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: email@kvack.org

--
Kind regards,
Minchan Kim