Re: [PATCH 0/4] staging: zsmalloc: various cleanups/improvments

Minchan Kim
2013-01-28T23:44:09Z

On Mon, Jan 28, 2013 at 11:07:10AM -0600, Seth Jennings wrote:
> On 01/27/2013 09:47 PM, Minchan Kim wrote:
> > Hi Seth,
> >
> > On Fri, Jan 25, 2013 at 11:46:14AM -0600, Seth Jennings wrote:
> >> These patches are the first 4 patches of the zswap patchset I
> >> sent out previously. Some recent commits to zsmalloc and
> >> zcache in staging-next forced a rebase. While I was at it, Nitin
> >> (zsmalloc maintainer) requested I break these 4 patches out from
> >> the zswap patchset, since they stand on their own.
> >
> > [2/4] and [4/4] is okay to merge current zsmalloc in staging but
> > [1/4] and [3/4] is dependent on zswap so it should be part of
> > zswap patchset.
>
> Just to clarify, patches 1 and 3 are _not_ dependent on zswap. They
> just introduce changes that are only needed by zswap.

I don't think so. If zswap might be not merged, we don't need [1, 3]
at the moment. You could argue that [1, 3] make zsmalloc more flexible
and I agree. BUT I want it when we have needs. It would be not too late.
So [1,3] should be part of zswap patchset.

>
> Seth
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: email@kvack.org

--
Kind regards,
Minchan Kim