From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] fix 32-bit compile warning from printk()
Date: Tue, 29 Jan 2013 02:54:28 -0800 [thread overview]
Message-ID: <20130129025428.918e295c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20130128191939.7F67966B@kernel.stglabs.ibm.com>
On Mon, 28 Jan 2013 11:19:39 -0800 Dave Hansen <dave@linux.vnet.ibm.com> wrote:
> My patch "Fix kvm's use of __pa() on percpu areas" introduced a
> compile warning:
>
> arch/x86/kernel/kvm.c: In function 'kvm_register_steal_time':
> arch/x86/kernel/kvm.c:302:3: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'phys_addr_t' [-Wformat]
>
> According to: Documentation/printk-formats.txt
>
> If <type> is dependent on a config option for its size
> (e.g., phys_addr_t) ... use a format specifier of its
> largest possible type and explicitly cast to it.
>
> So, we'll do just that. We will consider it an unsigned long
> long, and cast to it explicitly.
Please note that I have
http://ozlabs.org/~akpm/mmots/broken-out/lib-vsprintf-add-%25pa-format-specifier-for-phys_addr_t-types.patch
queued for 3.8.
next prev parent reply other threads:[~2013-01-29 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 19:19 [PATCH] fix 32-bit compile warning from printk() Dave Hansen
2013-01-29 10:54 ` Andrew Morton [this message]
2013-01-29 10:55 ` Andrew Morton
2013-02-13 16:31 ` Randy Dunlap
2013-02-13 16:39 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129025428.918e295c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox