From: Ingo Molnar <mingo@kernel.org>
To: "Wang, Song-Bo (Stoney)" <song-bo.wang@hp.com>
Cc: "mingo.kernel.org@gmail.com" <mingo.kernel.org@gmail.com>,
Yinghai Lu <yinghai@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Zhang, Lin-Bao (Linux Kernel R&D)" <linbao.zhang@hp.com>,
"Pearson, Greg" <greg.pearson@hp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"suresh.b.siddha@intel.com" <suresh.b.siddha@intel.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] x86/apic: check FADT settings after enable x2apic
Date: Tue, 29 Jan 2013 09:49:14 +0100 [thread overview]
Message-ID: <20130129084914.GB5350@gmail.com> (raw)
In-Reply-To: <FE3E8B88161FFE48B03E3B93408433EC671027BC@G9W0754.americas.hpqcorp.net>
* Wang, Song-Bo (Stoney) <song-bo.wang@hp.com> wrote:
> [...] Due to this mode mismatch, with specific HW
> configurations, there will be intermittent lost interrupts,
> which could result in a hang or data loss.
That's the key piece of information that was missing - which
should be put into the changelog into a very prominent place.
> Logically, there is a mismatch because the kernel missed
> detection on HW configurations, and we should fix it, right?
> Do we need more detailed information?
No, the above sentence is more than enough and the fix looks
nice. Note that this sentence is more useful to users than the
rest of the changelog combined!
Thanks,
Ingo
next prev parent reply other threads:[~2013-01-29 8:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 1:50 [PATCH] x86/apic: check FADT settings after enable x2apic Stoney Wang
2013-01-28 5:05 ` Wang, Song-Bo (Stoney)
2013-01-28 6:57 ` Yinghai Lu
2013-01-28 10:11 ` Ingo Molnar
2013-01-28 18:10 ` Yinghai Lu
2013-01-29 7:47 ` Ingo Molnar
2013-01-29 8:43 ` Wang, Song-Bo (Stoney)
2013-01-29 8:49 ` Ingo Molnar [this message]
2013-01-29 21:30 ` Yinghai Lu
2013-01-29 21:52 ` Yinghai Lu
2013-01-31 11:32 ` Ingo Molnar
2013-01-31 15:56 ` Yinghai Lu
2013-02-04 6:41 ` Wang, Song-Bo (Stoney)
2013-02-04 11:03 ` Ingo Molnar
2013-02-04 20:29 ` [PATCH] x86, apic: Check fadt x2apic phys in x2apic_phys_probe() Yinghai Lu
2013-02-05 12:24 ` Ingo Molnar
2013-02-05 16:53 ` Yinghai Lu
2013-02-06 13:16 ` Ingo Molnar
2013-02-06 17:10 ` Yinghai Lu
2013-02-07 18:53 ` [PATCH v4] " Yinghai Lu
2013-02-11 12:37 ` [tip:x86/urgent] x86/apic: Work around boot failure on HP ProLiant DL980 G7 Server systems tip-bot for Stoney Wang
2013-02-18 8:52 ` [PATCH v4] x86, apic: Check fadt x2apic phys in x2apic_phys_probe() Lin-Bao Zhang
2013-02-18 17:13 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129084914.GB5350@gmail.com \
--to=mingo@kernel.org \
--cc=greg.pearson@hp.com \
--cc=hpa@zytor.com \
--cc=linbao.zhang@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo.kernel.org@gmail.com \
--cc=mingo@elte.hu \
--cc=song-bo.wang@hp.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).