From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754873Ab3A2ItU (ORCPT ); Tue, 29 Jan 2013 03:49:20 -0500 Received: from mail-bk0-f54.google.com ([209.85.214.54]:34111 "EHLO mail-bk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753963Ab3A2ItS (ORCPT ); Tue, 29 Jan 2013 03:49:18 -0500 Date: Tue, 29 Jan 2013 09:49:14 +0100 From: Ingo Molnar To: "Wang, Song-Bo (Stoney)" Cc: "mingo.kernel.org@gmail.com" , Yinghai Lu , "H. Peter Anvin" , Thomas Gleixner , "Zhang, Lin-Bao (Linux Kernel R&D)" , "Pearson, Greg" , "linux-kernel@vger.kernel.org" , "suresh.b.siddha@intel.com" , Ingo Molnar Subject: Re: [PATCH] x86/apic: check FADT settings after enable x2apic Message-ID: <20130129084914.GB5350@gmail.com> References: <1358214636-4801-1-git-send-email-song-bo.wang@hp.com> <20130128101135.GD7168@gmail.com> <20130129074746.GA594@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Wang, Song-Bo (Stoney) wrote: > [...] Due to this mode mismatch, with specific HW > configurations, there will be intermittent lost interrupts, > which could result in a hang or data loss. That's the key piece of information that was missing - which should be put into the changelog into a very prominent place. > Logically, there is a mismatch because the kernel missed > detection on HW configurations, and we should fix it, right? > Do we need more detailed information? No, the above sentence is more than enough and the fix looks nice. Note that this sentence is more useful to users than the rest of the changelog combined! Thanks, Ingo