Re: [PATCH 1/2] sched: move scheduler sysctl bits into dedicated header file

Steven Rostedt
2013-01-29T18:05:29Z

On Tue, 2013-01-29 at 11:57 -0600, Clark Williams wrote:

> > > +/* provide a home for sysctl scheduler tuning knobs */
> > > +
> > > +/*
> > > + * default timeslice is 100 msecs (used only for SCHED_RR tasks).
> > > + * Timeslices get refilled after they expire.
> > > + */
> > > +#define RR_TIMESLICE (100 * HZ / 1000)
> >
> > It seems this line came from sched.h but I can't find that part
> > deleted.
> >
>
> Arggghh! I reorganized the commits and didn't remove RR_TIMESLICE when
> I moved it. I'm surprised it compiled.
>
> I can generate a new patchset or let Ingo just remove it from sched.h.

gcc won't warn if you define a macro to what it is already defined to.

#define foo bar
#define foo bar

won't warn

#define foo bar
#define foo cat

will.

-- Steve