Re: [PATCH 1/2] sched: move scheduler sysctl bits into dedicated header file

Clark Williams
2013-01-29T17:56:07Z

[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]

On Tue, 29 Jan 2013 09:12:45 +0800
Li Zefan <lizefan@huawei.com> wrote:

> > -extern void sched_autogroup_create_attach(struct task_struct *p);
> > -extern void sched_autogroup_detach(struct task_struct *p);
> > -extern void sched_autogroup_fork(struct signal_struct *sig);
> > -extern void sched_autogroup_exit(struct signal_struct *sig);
> > -#ifdef CONFIG_PROC_FS
> > -extern void proc_sched_autogroup_show_task(struct task_struct *p, struct seq_file *m);
> > -extern int proc_sched_autogroup_set_nice(struct task_struct *p, int nice);
> > -#endif
> > -#else
> > -static inline void sched_autogroup_create_attach(struct task_struct *p) { }
> > -static inline void sched_autogroup_detach(struct task_struct *p) { }
> > -static inline void sched_autogroup_fork(struct signal_struct *sig) { }
> > -static inline void sched_autogroup_exit(struct signal_struct *sig) { }
> > -#endif
>
> but those function declarations have nothing to do with sysctl..
>
> > -
> > -#ifdef CONFIG_CFS_BANDWIDTH
> > -extern unsigned int sysctl_sched_cfs_bandwidth_slice;
> > -#endif
> > -
>

True, but they're all under the SCHED_AUTOGROUP config variable along
with:
extern unsigned int sysctl_sched_autogroup_enabled;

So I thought I'd keep them all grouped together.

I can move the prototypes back into sched.h but the whole reason for
doing this is to reduce the size of sched.

Guess I'll let Ingo make the call here.

Clark

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]