From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753460Ab3A3Dwu (ORCPT ); Tue, 29 Jan 2013 22:52:50 -0500 Received: from li9-11.members.linode.com ([67.18.176.11]:46133 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753016Ab3A3Dws (ORCPT ); Tue, 29 Jan 2013 22:52:48 -0500 Date: Tue, 29 Jan 2013 22:52:43 -0500 From: "Theodore Ts'o" To: Stephen Warren Cc: Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Warren Subject: Re: [PATCH] ext4: only define label failed_mount8 when used Message-ID: <20130130035243.GC25006@thunk.org> Mail-Followup-To: Theodore Ts'o , Stephen Warren , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Warren References: <1359504540-23474-1-git-send-email-swarren@wwwdotorg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1359504540-23474-1-git-send-email-swarren@wwwdotorg.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 29, 2013 at 05:09:00PM -0700, Stephen Warren wrote: > From: Stephen Warren > > This fixes: > > fs/ext4/super.c: In function 'ext4_fill_super': > fs/ext4/super.c:4040:1: warning: label 'failed_mount8' defined but not used > > This label is only jumped to by code under ifdef CONFIG_QUOTA, so only > define the label in that case too. > > Signed-off-by: Stephen Warren This is already fixed in the ext4 dev tree. I assume you noticed this in linux-next? It should be fixed up in tomorrow's cut. - Ted