From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756584Ab3A3XeN (ORCPT ); Wed, 30 Jan 2013 18:34:13 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33057 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755407Ab3A3XeK (ORCPT ); Wed, 30 Jan 2013 18:34:10 -0500 Date: Wed, 30 Jan 2013 15:34:08 -0800 From: Andrew Morton To: Seth Jennings Cc: Greg Kroah-Hartman , Nitin Gupta , Minchan Kim , Konrad Rzeszutek Wilk , Dan Magenheimer , Robert Jennings , Jenifer Hopper , Mel Gorman , Johannes Weiner , Rik van Riel , Larry Woodman , Benjamin Herrenschmidt , Dave Hansen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCHv4 2/7] zsmalloc: promote to lib/ Message-Id: <20130130153408.fa099efb.akpm@linux-foundation.org> In-Reply-To: <51094A39.8050206@linux.vnet.ibm.com> References: <1359495627-30285-1-git-send-email-sjenning@linux.vnet.ibm.com> <1359495627-30285-3-git-send-email-sjenning@linux.vnet.ibm.com> <20130129145134.813672cf.akpm@linux-foundation.org> <51094A39.8050206@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Jan 2013 10:28:41 -0600 Seth Jennings wrote: > Question, are you saying that you'd like to see the zsmalloc promotion > in a separate patch? > > My reason for including the zsmalloc promotion inside the zswap > patches was that it promoted and introduced a user all together. > However, I don't have an issue with breaking it out. Keeping it all in the one series is logical. I want to see the code get the normal explain/review/comment process. Michan has been doing sterling work here but I don't think the rest of us understand the code as well as we can and should.