From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756025Ab3A3Qxj (ORCPT ); Wed, 30 Jan 2013 11:53:39 -0500 Received: from mail-ea0-f176.google.com ([209.85.215.176]:34146 "EHLO mail-ea0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755988Ab3A3Qxe (ORCPT ); Wed, 30 Jan 2013 11:53:34 -0500 Date: Wed, 30 Jan 2013 17:53:21 +0100 From: Fabio Baltieri To: Viresh Kumar Cc: "Rafael J. Wysocki" , cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, Linus Walleij , swarren@wwwdotorg.org, linaro-dev@lists.linaro.org, Nicolas Pitre , mathieu.poirier@linaro.org, Joseph Lo , linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 3/4] cpufreq: conservative: call dbs_check_cpu only when necessary Message-ID: <20130130165321.GD30559@balto.lan> References: <1359550803-18577-1-git-send-email-fabio.baltieri@linaro.org> <1359550803-18577-4-git-send-email-fabio.baltieri@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux balto 3.8.0-rc3-00668-g55706d3 x86_64 GNU/Linux User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 30, 2013 at 09:23:22PM +0530, Viresh Kumar wrote: > On 30 January 2013 18:30, Fabio Baltieri wrote: > > Modify conservative timer to not resample CPU utilization if recently > > sampled from another SW coordinated core. > > > > Signed-off-by: Fabio Baltieri > > We are again doing the same mistake which i fixed with: > > commit 4471a34f9a1f2da220272e823bdb8e8fa83a7661 > Author: Viresh Kumar > Date: Fri Oct 26 00:47:42 2012 +0200 > > cpufreq: governors: remove redundant code Can't argue with this, but the two had some subdle differences (namely th two dbs_info structures) and I opted to not mess up forcing some non-obvious common code. Feel free to suggest a strategy. Thanks, Fabio -- Fabio Baltieri